From: "Maciej W. Rozycki" <macro@embecosm.com>
To: gcc-patches@gcc.gnu.org
Cc: Kito Cheng <kito.cheng@gmail.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Andrew Waterman <andrew@sifive.com>,
Jim Wilson <jim.wilson.gcc@gmail.com>
Subject: [PATCH] RISC-V: Standardize formatting of SFB ALU conditional move
Date: Tue, 26 Jul 2022 19:38:01 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.2.20.2207261916490.10833@tpp.orcam.me.uk> (raw)
Standardize the formatting of SFB ALU conditional move operations from:
beq a2,zero,1f; mv a0,zero; 1: # movcc
to:
beq a2,zero,1f # movcc
mv a0,zero
1:
for consistency with other assembly code produced. No functional change.
gcc/
* gcc/config/riscv/riscv.md (*mov<GPR:mode><X:mode>cc): Fix
output pattern formatting.
---
Hi,
No regressions in `-mtune=sifive-7-series' testing except for:
FAIL: gcc.target/riscv/pr105314.c -O0 scan-assembler-not \tbeq\t
FAIL: gcc.target/riscv/pr105314.c -O1 scan-assembler-not \tbeq\t
FAIL: gcc.target/riscv/pr105314.c -O2 scan-assembler-not \tbeq\t
FAIL: gcc.target/riscv/pr105314.c -O3 -g scan-assembler-not \tbeq\t
FAIL: gcc.target/riscv/pr105314.c -Os scan-assembler-not \tbeq\t
FAIL: gcc.target/riscv/pr105314.c -O2 -flto -fno-use-linker-plugin -flto-partition=none scan-assembler-not \tbeq\t
FAIL: gcc.target/riscv/pr105314.c -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects scan-assembler-not \tbeq\t
as expected due to the brokenness of the test case, as discussed here:
<https://gcc.gnu.org/pipermail/gcc-patches/2022-July/598542.html> (still
unresolved).
OK to apply?
Maciej
---
gcc/config/riscv/riscv.md | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
gcc-riscv-movcc-format.diff
Index: gcc/gcc/config/riscv/riscv.md
===================================================================
--- gcc.orig/gcc/config/riscv/riscv.md
+++ gcc/gcc/config/riscv/riscv.md
@@ -2187,8 +2187,8 @@
(match_operand:GPR 4 "sfb_alu_operand" "rJ,IL")))]
"TARGET_SFB_ALU"
"@
- b%C5 %1,%z2,1f; mv %0,%z4; 1: # movcc
- b%C5 %1,%z2,1f; li %0,%4; 1: # movcc"
+ b%C5\t%1,%z2,1f\t# movcc\;mv\t%0,%z4\n1:
+ b%C5\t%1,%z2,1f\t# movcc\;li\t%0,%4\n1:"
[(set_attr "length" "8")
(set_attr "type" "sfb_alu")
(set_attr "mode" "<GPR:MODE>")])
next reply other threads:[~2022-07-26 18:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 18:38 Maciej W. Rozycki [this message]
2022-08-18 14:40 ` [PING][PATCH] " Maciej W. Rozycki
2022-08-18 14:47 ` Kito Cheng
2022-08-18 15:54 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.2207261916490.10833@tpp.orcam.me.uk \
--to=macro@embecosm.com \
--cc=andrew@sifive.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jim.wilson.gcc@gmail.com \
--cc=kito.cheng@gmail.com \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).