From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by sourceware.org (Postfix) with ESMTPS id DF1BA3857C51 for ; Thu, 28 Jul 2022 13:21:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DF1BA3857C51 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-lj1-x233.google.com with SMTP id q7so1915204ljp.13 for ; Thu, 28 Jul 2022 06:21:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=8nz39/GWIjQYjmKxJ5napkU7aWN2PJWXi1floW0sRNE=; b=TO52JU6F7QPbVkWBBhn3EEZkllh8cQ5L1bYIZqD4Y2SOuX6r8zQ/QB+tVA1ThgfAoh EJhaoKFv/5/vTdkSChQQc+gldHug8oJ7gM9zew9j8fCw4YoVRm+VKSLbzBK/zIyBqhPT tiUfihZ3kJMLLiQKJlTQlIpT143OK3Wh1SCbyQuyU+hf1fRjAM/ut96jb9xEkENs8DRF AMG6/uGy5H8Yj/PJGXVKpwNPUv0Ji/e6om4fXR9yFldapKuPy5xhog6ryHdpVj9c1yrv 6ktBsUuFA2ur+kD0uDQEKIsKZsQnCXoeFIlutfFTmYBrUyljYPJaBXTP0biVoaRoSNLZ 4OTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=8nz39/GWIjQYjmKxJ5napkU7aWN2PJWXi1floW0sRNE=; b=x0R5/uK0Hy2hCjltKu7SCCxXiXtgXLOIryLMzeBOqGXxx47bM7E9MdqLXTXnNV4Q95 VpKz8fU91cdXdzEAUR90y91QQawaFqxckpfHUiaHnchLNrrQHHZRkHZBeA6I4jB0BJ3s Phe2L8zOXz3PtVpTOK/vwmJ217pklIGiQjjQ+OrDK7WGBsdp3RnekKRE2Xe8MOsC215m cIvMGnyxIxde2JAEWvFr9/w2A5MnONCh+ptQ+xbP8iabpS9Lo+bAS9JClW1g5ev+Vg/a nBECQXbeZoS27XmqvKC+/OHSRNeoKQ+Qmk2hi7LMgPVYxM2MnJGCmMgNct8i5bqT/UOJ xH1w== X-Gm-Message-State: AJIora87xoCANblBBfSYZA0HPW5hBr5+G8KKDnN5Y24K/wa4IsXharPP fdmq0MJjjVsHInqOK/QwuwMPRg== X-Google-Smtp-Source: AGRyM1s0f1Eayd8ClnF93q7b0HLxK3NQYSWr+as5ZdrMkvMfwn4fKhr3LxnqhW0RAVWK7CkomJxddQ== X-Received: by 2002:a2e:a287:0:b0:25d:b515:430c with SMTP id k7-20020a2ea287000000b0025db515430cmr9568138lja.358.1659014467887; Thu, 28 Jul 2022 06:21:07 -0700 (PDT) Received: from [192.168.219.3] ([78.8.192.131]) by smtp.gmail.com with ESMTPSA id o22-20020a05651205d600b00489d7fec4f5sm199955lfo.122.2022.07.28.06.21.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Jul 2022 06:21:07 -0700 (PDT) Date: Thu, 28 Jul 2022 14:20:46 +0100 (BST) From: "Maciej W. Rozycki" To: Kito Cheng cc: GCC Patches , Andrew Waterman Subject: Re: [PING][PATCH v2] RISC-V: Split unordered FP comparisons into individual RTL insns In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jul 2022 13:21:12 -0000 Hi Kito, > I am convinced that is OK for now, I agree modeling fflags would be a > rabbit hole, I tried to build a full GNU toolchain with my quick patch > and saw many ICE during build libraries, that definitely should be a > long-term optimization project. > > Although I'm thinking if we should default -fno-trapping-math for > RISC-V, because RISC-V didn't trap for any floating point operations, > however I think that would be another topic. No need to do anything for RISC-V I believe, as Richard has mentioned that's been his plan for GCC 13 compiler-wide; see the discussion here: for further details. > so you got my LGTM :) I have applied this change now then, thank you for your review. Maciej