From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=M1i9=DF=embecosm.com=macro@sourceware.org>
Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435])
	by sourceware.org (Postfix) with ESMTPS id D60833858C33
	for <gcc-patches@gcc.gnu.org>; Wed, 19 Jul 2023 14:34:29 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D60833858C33
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com
Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-3159d75606dso6641372f8f.1
        for <gcc-patches@gcc.gnu.org>; Wed, 19 Jul 2023 07:34:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=embecosm.com; s=google; t=1689777268; x=1690382068;
        h=mime-version:user-agent:references:message-id:in-reply-to:subject
         :cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;
        bh=1BL7t8eZY1NkOrr7P0+flhf0JvSp7EVON8FYrcxjsgg=;
        b=RljZ+cvcdhNsu7ETcewnOpwolgsGUxy26V+K2iXGhO1yZPSnc0t0263nsv+9JsWiRu
         o1Xwa77kEMxnlIekSykbqSiH5DveGMLO4viAKlkIVLXC9EZAbhuFIJkhRgkH2B3s+clh
         MYBoSiIgwapjrWJ3osZ43AAg1nC7UuwmJmplpJLJgCNfaRx2sQ60xQo8dNtB1gEeJM7u
         WmurKFyuBc5tHpac1JtSNu0JPWOXimPQLzwB5fKfueXCJLDvCVPPiSr6cRWWn9ifoxgz
         6lXzRsbmdiCR2zGYWti0dozUUH3hcj0d0+b+YMCFGWzVL3LngbDEeaX6Ttz/gEWhuwvK
         5o1w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20221208; t=1689777268; x=1690382068;
        h=mime-version:user-agent:references:message-id:in-reply-to:subject
         :cc:to:from:date:x-gm-message-state:from:to:cc:subject:date
         :message-id:reply-to;
        bh=1BL7t8eZY1NkOrr7P0+flhf0JvSp7EVON8FYrcxjsgg=;
        b=CRxICmJTkfqrWz71rUokr+cX6hxK4Uj21bSCWrc9610DJy19OsrGLWoLV9L6RpLtqt
         WuCnySPYZei2gKC1loCfNnIWjhz/HBo4lru6xJvF2YyvcsPjo8R9GZNu4rxKQTqDoKfV
         /Bsg2dEGHTOUCgEtQQtMTUB9uEL+h9lIYAPIE+XAvxT3KgTEs2M23UF4rJo9bA4EXpga
         x4d4nUNvdGEXkilRGEFaB19wvZYATqtTjWSYRTaMOF1kre9E0u4aH4RkWS7bO3ueCpOy
         WbqVYhv6RBe3GSMomfqFTj58GsEQbO87ZUgUvrLir59COlna1LlWu1tSBsCG+49Nl2vt
         48lw==
X-Gm-Message-State: ABy/qLZGYE0CcXhyY9cufiy4Xcngyda5HY5UDgnOAW9ht+zBkAHZ4Zva
	MgcK+059q0G8AWnVj9e0MSzVug==
X-Google-Smtp-Source: APBJJlF5GRzoRTQ94/sxTV2SloW+A2SbdUTEZ+t0/ZoJbw4aGjdzaoEF06J1Qczm+iw8Bd/PpRLWeQ==
X-Received: by 2002:adf:db49:0:b0:313:e3a8:b47c with SMTP id f9-20020adfdb49000000b00313e3a8b47cmr85084wrj.8.1689777268194;
        Wed, 19 Jul 2023 07:34:28 -0700 (PDT)
Received: from [192.168.0.201] ([212.69.42.53])
        by smtp.gmail.com with ESMTPSA id x15-20020a05600c21cf00b003fbbe41fd78sm1895411wmj.10.2023.07.19.07.34.27
        (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
        Wed, 19 Jul 2023 07:34:27 -0700 (PDT)
Date: Wed, 19 Jul 2023 15:34:26 +0100 (BST)
From: "Maciej W. Rozycki" <macro@embecosm.com>
To: Richard Biener <richard.guenther@gmail.com>
cc: YunQiang Su <yunqiang.su@cipunited.com>, 
    Rainer Orth <ro@cebitec.uni-bielefeld.de>, 
    Mike Stump <mikestump@comcast.net>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 2/3] testsuite: Require 128-bit vectors for
 bb-slp-pr95839.c
In-Reply-To: <CAFiYyc0JBDFQBxS_A+80pcQ1CWUTYacwp+RkG3Qys3gC84c8Dw@mail.gmail.com>
Message-ID: <alpine.DEB.2.20.2307191134510.28892@tpp.orcam.me.uk>
References: <alpine.DEB.2.20.2307062118070.28892@tpp.orcam.me.uk> <alpine.DEB.2.20.2307062153310.28892@tpp.orcam.me.uk> <CAFiYyc23ujqdOfJ=R5uQL1YycJvxgdiyMuYY=-+J2ppSu7JDvA@mail.gmail.com> <alpine.DEB.2.20.2307111423190.28892@tpp.orcam.me.uk>
 <CAFiYyc0JBDFQBxS_A+80pcQ1CWUTYacwp+RkG3Qys3gC84c8Dw@mail.gmail.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On Wed, 12 Jul 2023, Richard Biener wrote:

> > > That said, we should handle this better so can you file an
> > > enhancement bugreport for this?
> >
> >  Filed as PR -optimization/110630.
> 
> Thanks!

 Thanks for making this improvement.  I've checked MIPS results and code 
produced now is as follows:

	daddiu	$sp,$sp,-64
	sd	$5,24($sp)
	sd	$7,40($sp)
	ldc1	$f0,24($sp)
	ldc1	$f1,40($sp)
	sd	$4,16($sp)
	sd	$6,32($sp)
	ldc1	$f2,32($sp)
	add.ps	$f1,$f0,$f1
	ldc1	$f0,16($sp)
	add.ps	$f0,$f0,$f2
	sdc1	$f1,56($sp)
	ld	$3,56($sp)
	sdc1	$f0,48($sp)
	ld	$2,48($sp)
	jr	$31
	daddiu	$sp,$sp,64

which does do vector stuff now, although it's still considerably worse 
than my handwritten example:

> >         dmtc1   $4,$f0
> >         dmtc1   $5,$f1
> >         dmtc1   $6,$f2
> >         dmtc1   $7,$f3
> >         add.ps  $f0,$f0,$f1
> >         add.ps  $f2,$f2,$f3
> >         dmfc1   $2,$f0
> >         jr      $31
> >         dmfc1   $3,$f2

Or I'd say it's pretty terrible, but given the current situation with the 
MIPS backend I'm going to leave it to the new maintainer to sort out.

> >  Do you agree it still makes sense to include bb-slp-pr95839-v8.c with the
> > testsuite?
> 
> Sure, more coverage is always  nice.

 Thanks, committed (with the `vect64' requirement removed, as we can take 
it for granted with `vect_float').

  Maciej