From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by sourceware.org (Postfix) with ESMTPS id 4CCD2385700F for ; Thu, 20 Jul 2023 09:16:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4CCD2385700F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-3158a5e64b6so454212f8f.0 for ; Thu, 20 Jul 2023 02:16:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; t=1689844593; x=1690449393; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=kbWgZZGZDr0EIerSLa53U/9s8FJsjrkffGLncTa8VS4=; b=KCnKYQKQPHTzas3xsbs7QpT0z1Qf7IGHSpXqzHCdCUAPZLcs5AoxR8aTLs0xKHAmnK M2CLwk0+J2HYGV87AKedJkGmnSIdJW5G/ycT2TObfcFTiSuZCDOBfHafu2XuAEsq29mZ SwDAIdRvfctfcFusvxiWYmzmjpLRBk7Afe114Nw9qXeCGbuMFigUK2MZKTmx5TcSa/7R J/AtZMNcqmq6mRfNeLACziNhkKXvbOoyqfw8w4PwZQ5R61hvezFlyXz/cWYfFhiAx35N yyrG+OkO2e931c4EDGimNvm5/1LYxKAq4Gv41hZaJ5D1zkZnf/zGMJKaXKi3WRH0KFtI L1zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689844593; x=1690449393; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kbWgZZGZDr0EIerSLa53U/9s8FJsjrkffGLncTa8VS4=; b=aU/s69YNBZQIe+N4jgamkMkJ/pGtWP4Qy1ieY5km/dVq6b5iWpfyal6cHnMN67sc34 nsFvUZzzeDd+FPX8nvNfUrE8It8rziLNcgX3DOKaKI+xhJ4KOa2jVuSuWDf4Jv0UMWZe K3gKMQziXY85h1ZA1PMJiQBE9i0LpGgFCdY5mWaOMoxIKNn0j0kfTH+dV2yaKZ61sMX3 6n22lepI4RgK2cCpcpSH4ObFU4tis4T4SuIjZauY+6cEO1IrRb2l9DDzi72jgZkRB6sK Zd9nB8h/4+RHGU29Y8vYM2BHFqSbrd5PL5nm2yC7zjmlhg84LDlSwAEWevx9C/s8wWdL jZ5w== X-Gm-Message-State: ABy/qLayXUdD0WHF+O5IV1CcAsFmNRwsOxteAaVuqDBbPiGu4eDjWGCY kpLd2yoSFQjCw/WOve5BqGjsYw== X-Google-Smtp-Source: APBJJlGEkE4XYCP9MZSpTsnW0Yh3YofCkNoLK83o65mBxQiurfY5yp4ElwyudKL7wmycuuy2zLyfcQ== X-Received: by 2002:adf:dc05:0:b0:314:11ea:480d with SMTP id t5-20020adfdc05000000b0031411ea480dmr1510689wri.9.1689844593538; Thu, 20 Jul 2023 02:16:33 -0700 (PDT) Received: from [172.16.6.190] ([194.168.26.145]) by smtp.gmail.com with ESMTPSA id j11-20020a5d448b000000b003143853590csm710111wrq.104.2023.07.20.02.16.32 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Jul 2023 02:16:32 -0700 (PDT) Date: Thu, 20 Jul 2023 10:16:23 +0100 (BST) From: "Maciej W. Rozycki" To: Richard Biener cc: YunQiang Su , Rainer Orth , Mike Stump , gcc-patches@gcc.gnu.org Subject: Re: [PATCH 2/3] testsuite: Require 128-bit vectors for bb-slp-pr95839.c In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 20 Jul 2023, Richard Biener wrote: > > Thanks for making this improvement. I've checked MIPS results and code > > produced now is as follows: > > > > daddiu $sp,$sp,-64 > > sd $5,24($sp) > > sd $7,40($sp) > > ldc1 $f0,24($sp) > > ldc1 $f1,40($sp) > > sd $4,16($sp) > > sd $6,32($sp) > > ldc1 $f2,32($sp) > > add.ps $f1,$f0,$f1 > > ldc1 $f0,16($sp) > > add.ps $f0,$f0,$f2 > > sdc1 $f1,56($sp) > > ld $3,56($sp) > > sdc1 $f0,48($sp) > > ld $2,48($sp) > > jr $31 > > daddiu $sp,$sp,64 > > > > which does do vector stuff now, although it's still considerably worse > > than my handwritten example: > > > > > > dmtc1 $4,$f0 > > > > dmtc1 $5,$f1 > > > > dmtc1 $6,$f2 > > > > dmtc1 $7,$f3 > > > > add.ps $f0,$f0,$f1 > > > > add.ps $f2,$f2,$f3 > > > > dmfc1 $2,$f0 > > > > jr $31 > > > > dmfc1 $3,$f2 > > > > Or I'd say it's pretty terrible, but given the current situation with the > > MIPS backend I'm going to leave it to the new maintainer to sort out. > > Yeah, I also wondered what is wrong ... I suspect it's the usual issue > of parameter passing causing spilling ... There's no such requirement in the psABI and I fail to see a plausible justification. And direct GPR<->FPR move patterns are available in the backend for the V2SF mode. Also there's no delay slot requirement even for these move instructions for MIPS64r1+ ISA levels, which have this paired-single FP format defined. It seems to me a plain bug (or missed optimisation if you prefer). Maciej