[r14-2639 Regression] FAIL: gcc.dg/vect/bb-slp-pr95839-v8.c scan-tree-dump slp2 "optimized: basic block" on Linux/x86_64

[r14-2639 Regression] FAIL: gcc.dg/vect/bb-slp-pr95839-v8.c scan-tree-dump slp2 "optimized: basic block" on Linux/x86_64

[haochen.jiang]

On Linux/x86_64,

c1e420549f2305efb70ed37e693d380724eb7540 is the first bad commit
commit c1e420549f2305efb70ed37e693d380724eb7540
Author: Maciej W. Rozycki <macro@embecosm.com>
Date:   Wed Jul 19 11:59:29 2023 +0100

    testsuite: Add 64-bit vector variant for bb-slp-pr95839.c

caused

FAIL: gcc.dg/vect/bb-slp-pr95839-v8.c -flto -ffat-lto-objects  scan-tree-dump slp2 "optimized: basic block"
FAIL: gcc.dg/vect/bb-slp-pr95839-v8.c scan-tree-dump slp2 "optimized: basic block"

with GCC configured with

../../gcc/configure --prefix=/export/users/haochenj/src/gcc-bisect/master/master/r14-2639/usr --enable-clocale=gnu --with-system-zlib --with-demangler-in-ld --with-fpmath=sse --enable-languages=c,c++,fortran --enable-cet --without-isl --enable-libmpx x86_64-linux --disable-bootstrap

To reproduce:

$ cd {build_dir}/gcc && make check RUNTESTFLAGS="vect.exp=gcc.dg/vect/bb-slp-pr95839-v8.c --target_board='unix{-m32}'"
$ cd {build_dir}/gcc && make check RUNTESTFLAGS="vect.exp=gcc.dg/vect/bb-slp-pr95839-v8.c --target_board='unix{-m32\ -march=cascadelake}'"

(Please do not reply to this email, for question about this report, contact me at haochen dot jiang at intel.com.)
(If you met problems with cascadelake related, disabling AVX512F in command line might save that.)
(However, please make sure that there is no potential problems with AVX512.)

Re: [r14-2639 Regression] FAIL: gcc.dg/vect/bb-slp-pr95839-v8.c scan-tree-dump slp2 "optimized: basic block" on Linux/x86_64

[Richard Biener]

On Thu, Jul 20, 2023 at 1:46 PM haochen.jiang via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> On Linux/x86_64,
>
> c1e420549f2305efb70ed37e693d380724eb7540 is the first bad commit
> commit c1e420549f2305efb70ed37e693d380724eb7540
> Author: Maciej W. Rozycki <macro@embecosm.com>
> Date:   Wed Jul 19 11:59:29 2023 +0100
>
>     testsuite: Add 64-bit vector variant for bb-slp-pr95839.c

I think the issue is we disable V2SF on ia32 because of the conflict
with MMX which we
don't want to use.

> caused
>
> FAIL: gcc.dg/vect/bb-slp-pr95839-v8.c -flto -ffat-lto-objects  scan-tree-dump slp2 "optimized: basic block"
> FAIL: gcc.dg/vect/bb-slp-pr95839-v8.c scan-tree-dump slp2 "optimized: basic block"
>
> with GCC configured with
>
> ../../gcc/configure --prefix=/export/users/haochenj/src/gcc-bisect/master/master/r14-2639/usr --enable-clocale=gnu --with-system-zlib --with-demangler-in-ld --with-fpmath=sse --enable-languages=c,c++,fortran --enable-cet --without-isl --enable-libmpx x86_64-linux --disable-bootstrap
>
> To reproduce:
>
> $ cd {build_dir}/gcc && make check RUNTESTFLAGS="vect.exp=gcc.dg/vect/bb-slp-pr95839-v8.c --target_board='unix{-m32}'"
> $ cd {build_dir}/gcc && make check RUNTESTFLAGS="vect.exp=gcc.dg/vect/bb-slp-pr95839-v8.c --target_board='unix{-m32\ -march=cascadelake}'"
>
> (Please do not reply to this email, for question about this report, contact me at haochen dot jiang at intel.com.)
> (If you met problems with cascadelake related, disabling AVX512F in command line might save that.)
> (However, please make sure that there is no potential problems with AVX512.)

Re: [r14-2639 Regression] FAIL: gcc.dg/vect/bb-slp-pr95839-v8.c scan-tree-dump slp2 "optimized: basic block" on Linux/x86_64

[Maciej W. Rozycki]

On Thu, 20 Jul 2023, Richard Biener wrote:

> > c1e420549f2305efb70ed37e693d380724eb7540 is the first bad commit
> > commit c1e420549f2305efb70ed37e693d380724eb7540
> > Author: Maciej W. Rozycki <macro@embecosm.com>
> > Date:   Wed Jul 19 11:59:29 2023 +0100
> >
> >     testsuite: Add 64-bit vector variant for bb-slp-pr95839.c
> 
> I think the issue is we disable V2SF on ia32 because of the conflict
> with MMX which we
> don't want to use.

 I'm not sure if I have a way to test with such a target.  Would you 
expect:

/* { dg-require-effective-target vect64 } */

to cover it?  If so, then I'll put it back as in the original version and 
post for Haochen to verify.

  Maciej

Re: [r14-2639 Regression] FAIL: gcc.dg/vect/bb-slp-pr95839-v8.c scan-tree-dump slp2 "optimized: basic block" on Linux/x86_64

[Richard Biener]

On Thu, Jul 20, 2023 at 3:13 PM Maciej W. Rozycki <macro@embecosm.com> wrote:
>
> On Thu, 20 Jul 2023, Richard Biener wrote:
>
> > > c1e420549f2305efb70ed37e693d380724eb7540 is the first bad commit
> > > commit c1e420549f2305efb70ed37e693d380724eb7540
> > > Author: Maciej W. Rozycki <macro@embecosm.com>
> > > Date:   Wed Jul 19 11:59:29 2023 +0100
> > >
> > >     testsuite: Add 64-bit vector variant for bb-slp-pr95839.c
> >
> > I think the issue is we disable V2SF on ia32 because of the conflict
> > with MMX which we
> > don't want to use.
>
>  I'm not sure if I have a way to test with such a target.  Would you
> expect:
>
> /* { dg-require-effective-target vect64 } */
>
> to cover it?  If so, then I'll put it back as in the original version and
> post for Haochen to verify.

Yeah, that should work here.

Richard.

>   Maciej

RE: [r14-2639 Regression] FAIL: gcc.dg/vect/bb-slp-pr95839-v8.c scan-tree-dump slp2 "optimized: basic block" on Linux/x86_64

[Jiang, Haochen]

> -----Original Message-----
> From: Richard Biener <richard.guenther@gmail.com>
> Sent: Thursday, July 20, 2023 9:28 PM
> To: Maciej W. Rozycki <macro@embecosm.com>
> Cc: haochen.jiang <haochenj@ecsmtp.sh.intel.com>; gcc-
> regression@gcc.gnu.org; gcc-patches@gcc.gnu.org; Jiang, Haochen
> <haochen.jiang@intel.com>
> Subject: Re: [r14-2639 Regression] FAIL: gcc.dg/vect/bb-slp-pr95839-v8.c
> scan-tree-dump slp2 "optimized: basic block" on Linux/x86_64
> 
> On Thu, Jul 20, 2023 at 3:13 PM Maciej W. Rozycki <macro@embecosm.com>
> wrote:
> >
> > On Thu, 20 Jul 2023, Richard Biener wrote:
> >
> > > > c1e420549f2305efb70ed37e693d380724eb7540 is the first bad commit
> > > > commit c1e420549f2305efb70ed37e693d380724eb7540
> > > > Author: Maciej W. Rozycki <macro@embecosm.com>
> > > > Date:   Wed Jul 19 11:59:29 2023 +0100
> > > >
> > > >     testsuite: Add 64-bit vector variant for bb-slp-pr95839.c
> > >
> > > I think the issue is we disable V2SF on ia32 because of the conflict
> > > with MMX which we don't want to use.
> >
> >  I'm not sure if I have a way to test with such a target.  Would you
> > expect:
> >
> > /* { dg-require-effective-target vect64 } */
> >
> > to cover it?  If so, then I'll put it back as in the original version
> > and post for Haochen to verify.

I suppose just commit to trunk and it should be ok since it is only -m32 issue.

Thx,
Haochen

> 
> Yeah, that should work here.
> 
> Richard.
> 
> >   Maciej

[committed] testsuite: Limit bb-slp-pr95839-v8.c to 64-bit vector targets

[Maciej W. Rozycki]

Only run bb-slp-pr95839-v8.c with targets that support vectors of 64 
bits, removing regressions with 32-bit x86 targets:

FAIL: gcc.dg/vect/bb-slp-pr95839-v8.c scan-tree-dump slp2 "optimized: basic block"
FAIL: gcc.dg/vect/bb-slp-pr95839-v8.c -flto -ffat-lto-objects  scan-tree-dump slp2 "optimized: basic block"

	gcc/testsuite/
	* gcc.dg/vect/bb-slp-pr95839-v8.c: Limit to `vect64' targets.
---
On Fri, 21 Jul 2023, Jiang, Haochen wrote:

> > > > I think the issue is we disable V2SF on ia32 because of the conflict
> > > > with MMX which we don't want to use.
> > >
> > >  I'm not sure if I have a way to test with such a target.  Would you
> > > expect:
> > >
> > > /* { dg-require-effective-target vect64 } */
> > >
> > > to cover it?  If so, then I'll put it back as in the original version
> > > and post for Haochen to verify.
> 
> I suppose just commit to trunk and it should be ok since it is only -m32 
> issue.

 Thanks for mentioning `-m32', I was able to use it to verify this change 
and confirm that the qualifier does indeed work for this configuration.  
Committed as posted then and apologies for messing this up.

  Maciej
---
 gcc/testsuite/gcc.dg/vect/bb-slp-pr95839-v8.c |    1 +
 1 file changed, 1 insertion(+)

gcc-test-bb-slp-pr95839-v8-fix.diff
Index: gcc/gcc/testsuite/gcc.dg/vect/bb-slp-pr95839-v8.c
===================================================================
--- gcc.orig/gcc/testsuite/gcc.dg/vect/bb-slp-pr95839-v8.c
+++ gcc/gcc/testsuite/gcc.dg/vect/bb-slp-pr95839-v8.c
@@ -1,5 +1,6 @@
 /* { dg-do compile } */
 /* { dg-require-effective-target vect_float } */
+/* { dg-require-effective-target vect64 } */
 /* { dg-additional-options "-w -Wno-psabi" } */
 
 typedef float __attribute__((vector_size(8))) v2f32;