From: "Maciej W. Rozycki" <macro@embecosm.com>
To: Kito Cheng <kito.cheng@gmail.com>
Cc: juzhe.zhong@rivai.ai, "Kito.cheng" <kito.cheng@sifive.com>,
gcc-patches <gcc-patches@gcc.gnu.org>,
Robin Dapp <rdapp.gcc@gmail.com>, "pan2.li" <pan2.li@intel.com>
Subject: Re: [PATCH] RISC-V: Return machine_mode rather than opt_machine_mode for get_mask_mode, NFC
Date: Mon, 31 Jul 2023 12:06:43 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.2.20.2307311203070.28892@tpp.orcam.me.uk> (raw)
In-Reply-To: <CA+yXCZCgM5J=QAV96M9bmrEsDDz+_yh630S4k-M=K=dCSfxayw@mail.gmail.com>
On Mon, 31 Jul 2023, Kito Cheng via Gcc-patches wrote:
> Pushed, thanks :)
This breaks compilation:
.../gcc/config/riscv/riscv-v.cc: In function 'void riscv_vector::expand_vec_series(rtx, rtx, rtx)':
.../gcc/config/riscv/riscv-v.cc:1251:16: error: unused variable 'mask_mode' [-Werror=unused-variable]
1251 | machine_mode mask_mode = get_mask_mode (mode);
| ^~~~~~~~~
.../gcc/config/riscv/riscv-v.cc: In function 'void riscv_vector::expand_vector_init_insert_elems(rtx, const riscv_vector::rvv_builder&, int)':
.../gcc/config/riscv/riscv-v.cc:2320:16: error: unused variable 'mask_mode' [-Werror=unused-variable]
2320 | machine_mode mask_mode = get_mask_mode (mode);
| ^~~~~~~~~
Please always at the very least build changes and verify that they cause
no new issues before submitting patches.
Maciej
next prev parent reply other threads:[~2023-07-31 11:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 6:52 Kito Cheng
2023-07-31 6:58 ` juzhe.zhong
2023-07-31 7:02 ` Kito Cheng
2023-07-31 11:06 ` Maciej W. Rozycki [this message]
2023-07-31 13:46 ` Kito Cheng
2023-07-31 14:03 ` Maciej W. Rozycki
2023-07-31 14:52 ` Kito Cheng
2023-07-31 15:20 ` Jeff Law
2023-07-31 15:55 ` Maciej W. Rozycki
2023-08-09 13:25 ` Maciej W. Rozycki
2023-07-31 15:50 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.2307311203070.28892@tpp.orcam.me.uk \
--to=macro@embecosm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=juzhe.zhong@rivai.ai \
--cc=kito.cheng@gmail.com \
--cc=kito.cheng@sifive.com \
--cc=pan2.li@intel.com \
--cc=rdapp.gcc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).