From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by sourceware.org (Postfix) with ESMTPS id E25A83858D33 for ; Wed, 9 Aug 2023 13:25:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E25A83858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-4fe61ae020bso6876217e87.2 for ; Wed, 09 Aug 2023 06:25:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; t=1691587507; x=1692192307; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=d85EEekpttmlK0O5dmWRk5w7G8QmdainicZ1aUSE/xY=; b=LsRuUD0ypcWVoL9WLmLAgTBy6To0SGQkgdS9V5QBrIzMh2XDNSBmxMHVnUk0j1DUKy sMeciD+oIyEyAMaOhJA3JtmPHjAAfHAC/4lRwYrOQDFUaUB4AyvyN9q72vklrZdl9GNW JtGTD6aZTkUZCbQagQEoPLWvQ1+t9rPBxuVl6BTj6lvFM1HDex/Dyvl5vWxMQIPh+ID0 qRgtBaXueGPmxUjPfaajs2yV8cr0yTN+pRXdMUfiuO2D97KiNjtm0YrgbpX717V123uy VxIEIpnan4oYVlZzqVHXAE7D+49D6J/Ak4T2uzI6DkBBERDitRFMJHWx96iF4+uhZtd0 duAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691587507; x=1692192307; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=d85EEekpttmlK0O5dmWRk5w7G8QmdainicZ1aUSE/xY=; b=HAaTwc83VIXRyqNsLIMM3OAU3niv9Bm6KFnfm6BQMffiSS1g46yTBIEbIComEw8S+v sKQIH62p3c3LA1AZBhRQg0POt/Pp9JGFAxiNGDWTCBQhArHex30+LGwOLGK3Meqx4DMn mUCapRQbbeA9OozSZQXUycYmezBUfVYsbI6DKvSrZmSMNJhj/bYkJA95ZkRrS4gUDMla ukXhU/A3iqpadkOBetVjCwMqS8YeDP8ibVSyndRE50cJqknRKAQIYJKZ7OEMYyU4Bm4K mgg6vI726INnY6QdsD4zEQCSa8aADBkJzNPpnMjuZWr3esnO6Vh7iitb5Gb6FV/uzcK7 XsNw== X-Gm-Message-State: AOJu0Yww4HCou69k9Bo2lBIl4dj/A9CxoH4Xk793c8p3q23uE4nRhin9 AyzrV/cg7mRuzUpJ6QJMXTtLXA== X-Google-Smtp-Source: AGHT+IHwtnqt7n/YbZSrkV/2Wdpy0wERqkDIagKBWEZZ/ND0FCcp4JYBrJaV3WHs49THBhZDhxbCtQ== X-Received: by 2002:a19:6d16:0:b0:4fb:740a:81ae with SMTP id i22-20020a196d16000000b004fb740a81aemr1518904lfc.16.1691587507117; Wed, 09 Aug 2023 06:25:07 -0700 (PDT) Received: from [192.168.219.3] ([78.8.192.131]) by smtp.gmail.com with ESMTPSA id x15-20020aa7d38f000000b00523372c86e7sm4335025edq.24.2023.08.09.06.25.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Aug 2023 06:25:06 -0700 (PDT) Date: Wed, 9 Aug 2023 14:25:03 +0100 (BST) From: "Maciej W. Rozycki" To: Jeff Law cc: Kito Cheng , Kito Cheng , juzhe.zhong@rivai.ai, gcc-patches , Robin Dapp , "pan2.li" Subject: Re: [PATCH] RISC-V: Return machine_mode rather than opt_machine_mode for get_mask_mode, NFC In-Reply-To: Message-ID: References: <20230731065228.69779-1-kito.cheng@sifive.com> <0bede5a1-3de3-d2ac-71db-29c634e99620@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 31 Jul 2023, Maciej W. Rozycki wrote: > > > That's a good suggestion! Thanks, let me try to apply myself workflow :) > > I'm thinking that as part of the CI POC being done by RISE that the base AMI > > image ought to be gcc-13 based and that we should configure the toolchains we > > build with -enable-werror-always. > > > > While we can't necessarily get every developer to embrace this workflow, we > > ought to be catching it quicker than we currently are. > > I wonder if we should enable the option by default, perhaps under certain > conditions such as matching the build compiler version, for builds made > from a Git checkout rather than a release tarball. I suspect some people > are simply not aware of this option. Also the Linux kernel community has bots that monitor the relevant mailing lists for patches, apply them, build in various configurations, and report back any issues, so when you submit a change that doesn't compile in some cases, then it's often within minutes that you get a notification, even before anyone has a chance to review your submission. That also helps maintainers catch such issues before a change gets merged anywhere. Cf. , . That surely hasn't come for free, someone had to make the infrastructure, and then with contemporary hardware the Linux kernel often builds within seconds, which we don't have the luxury of, but I wonder if it's an approach that has been previously considered for GCC. Overall I think the more effort we can offload to automata the less remains for us. Maciej