From: "Maciej W. Rozycki" <macro@embecosm.com>
To: Jeff Law <jeffreyalaw@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [committed] RISC-V: Fix INSN costing and more zicond tests
Date: Fri, 10 Nov 2023 01:32:03 +0000 (GMT) [thread overview]
Message-ID: <alpine.DEB.2.20.2311100108280.5892@tpp.orcam.me.uk> (raw)
In-Reply-To: <236780fb-a6cc-4e56-b490-0e44e56d5b06@gmail.com>
On Thu, 9 Nov 2023, Jeff Law wrote:
> > Can we have the insn costing reverted to correct calculation?
> What needs to happen is that code needs to be extended, not reverted. Many
> codes have to be synthesized based on the condition and the true/false arms.
> That's not currently accounted for.
How is maintaining zillions of variants of insn counts by hand (IIUC what
you mean) going to be more efficient (or even practical maintenance-wise)
than what the middle end did automagically? What exactly was wrong with
the previous approach, and then why didn't your change include a proof of
correctness in the form of testsuite cases verifying branch vs conditional
move costing stays the same (or gets corrected if applicable) across your
change?
I guess I'll post my patch series regardless on the presumption that
correct insn counting will have been reinstated for GCC 14 one way or
another (i.e. by reverting commit 44efc743acc0 locally in my tree and then
getting clean test results across the patch series) and we can take it
from there. Also to make sure we're on the same page.
I do hope it will be considered worthwhile despite this issue making it
not ready for testsuite verification, as not only it adds new features,
but it fixes numerous existing problems, plain bugs, and deficiencies as
well which we currently have in conditional move handling. But it relies
on correct costing for verification, which I couldn't have expected that
will get broken again (regardless of your clearly good intentions). And
I'd rather we had these test cases or otherwise costing regressions are
easily missed (as indicated here).
Maciej
next prev parent reply other threads:[~2023-11-10 1:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 22:37 Jeff Law
2023-10-13 4:02 ` Hans-Peter Nilsson
2023-11-09 14:33 ` Maciej W. Rozycki
2023-11-09 15:03 ` Jeff Law
2023-11-10 1:32 ` Maciej W. Rozycki [this message]
2023-11-09 15:47 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.2311100108280.5892@tpp.orcam.me.uk \
--to=macro@embecosm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).