From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by sourceware.org (Postfix) with ESMTPS id 694B43857C4A for ; Sun, 19 Nov 2023 05:36:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 694B43857C4A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 694B43857C4A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::531 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700372168; cv=none; b=IMpIfKfg3HkHiunVF8lrOPHbzruTAduCAPvGQXN1s6QTPdhXcHolcyxiVU5HWbY3LA6gfK8kDwcPeuGEL8NTj+8VPxe3nAbM9RQCbWZzIthlRRbZqucsqjdeLClWBKUseSqujhORM4M5zjD+qcDSEecN2KQFxx1l5MutNemya+A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700372168; c=relaxed/simple; bh=2jNmEiIBJ2MoV2AR7EWAifyEkhA/M9aOZMAKSxNJXXc=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=VTmS1q/5H0J7tsiaAar3/yN/iKB+WQY9/e/zsvJI3/1/mbEu/cTp69pICWoByEN5o4Fz0rzUbxD6y8V+UTvxY1he6+uH7I02cBtVEmQeV3hDpdQvUZqgj32jnqJPEgfsy3X+bwUIOzjcpKs+pbM+MiKmQ7R7B9PL/fMWXB9q+5I= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-53e2308198eso4761385a12.1 for ; Sat, 18 Nov 2023 21:36:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; t=1700372166; x=1700976966; darn=gcc.gnu.org; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=SQCJUnl3JVJg6CUD/dwVsRYRkaoWvF+XHNpqJEfPBWE=; b=KuSApKf0VTzvAk8foPMBzwhJsaBmSKtEq0QABMPBjB9OYFMD0pC9S3hlwPyL41oMDC Ay8rM8Htw9rGwnEDtqrJlwkdvx+MhIeeY4iF3X9dL+XR18Hu9OZjpqGG2WXiQZUXIheX zAYjqNyltFUenCccoY14YFNriZG4aDwYXeAH0wRp5084Q6sGp6WQtv6EVgPPPCZWwXRY YRuhIVX9bHTw46ZKohedVJOg9BV1Xm0pvhvsE8xnsIsb1GZYwQuVtnmTXAsAPlL69LuO mplNUe5R6dMyszLvSZE4eX476vNPoah+uivPE56LeF+O86d8dFqXHzIuLN6lSl8UYdw0 bbYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700372166; x=1700976966; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SQCJUnl3JVJg6CUD/dwVsRYRkaoWvF+XHNpqJEfPBWE=; b=bYMWml7Ll69fnF1B4ilay3qrxFJ1dwK56HQgKt3/3R3+MIgBtZxY5XMkiQoAgL4r6N +XNGTkXXXcI1UYbwUGIbl1A+QjxF7VAQcYOLsiyr/S8fmonJbCRxnIpNwaRojmVjDRzI a93tu625mlKXVKFPVW/A44sxta0lpdmResUhfZYnFnlA1rfM8Q9TC2cG1XT5Rvd/RWW4 t/FMZXhCFFsiYvs0F0JJozwLi4cXghTc9rvMU8UMeCINhOBojshJbsGivBP1e7VUCp0O FYs6nBOmTX8uGXFqHPkrerqnY88IeM830ZdtCs24kQI5JneW5AJHQtgRvgIEW4G3RrY6 QCKg== X-Gm-Message-State: AOJu0Yx+mouVL9JfxCkq9L0OIIJ8fu2iKZ8Qjv0EQBYE/w0OwwfwawuD xr5ZC9pDfKn3awqM0wGpKm09MddyXfGZvYI7IOEGaA== X-Google-Smtp-Source: AGHT+IF0Qa+VTb4y9QaGoOaoh5+XqazoAb5oaKuRuI7ScW31jZGB2ADq0H2WE98Yp9ezeTHWe3hmhA== X-Received: by 2002:a05:6402:14d6:b0:542:f28e:2947 with SMTP id f22-20020a05640214d600b00542f28e2947mr3041719edx.26.1700372166187; Sat, 18 Nov 2023 21:36:06 -0800 (PST) Received: from [192.168.219.3] ([78.8.192.131]) by smtp.gmail.com with ESMTPSA id v4-20020aa7d644000000b0053e3d8f1d9fsm2331619edr.67.2023.11.18.21.36.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 18 Nov 2023 21:36:05 -0800 (PST) Date: Sun, 19 Nov 2023 05:36:03 +0000 (GMT) From: "Maciej W. Rozycki" To: gcc-patches@gcc.gnu.org cc: Andrew Waterman , Jim Wilson , Kito Cheng , Palmer Dabbelt Subject: [PATCH 04/44] RISC-V: Sanitise NEED_EQ_NE_P case with `riscv_emit_int_compare' In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,URIBL_BLACK autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: For the NEED_EQ_NE_P `riscv_emit_int_compare' is documented to only emit EQ or NE comparisons against zero, however it does not catch incorrect use where a non-equality comparison has been requested and falls through to the general case then. Add a safety guard to catch such a case then. Arguably the NEED_EQ_NE_P case would best be moved into a function of its own, but let's leave it for a separate cleanup. gcc/ * config/riscv/riscv.cc (riscv_emit_int_compare): Bail out if NEED_EQ_NE_P but the comparison is neither EQ nor NE. --- FWIW the structure of code here clearly shows the NEED_EQ_NE_P case has been bolted on as an afterthought rather than how this piece would look if written from scratch right away. Let's defer any further cleanups at this stage of the development cycle though. --- gcc/config/riscv/riscv.cc | 1 + 1 file changed, 1 insertion(+) gcc-riscv-emit-int-compare-need-eq-ne.diff Index: gcc/gcc/config/riscv/riscv.cc =================================================================== --- gcc.orig/gcc/config/riscv/riscv.cc +++ gcc/gcc/config/riscv/riscv.cc @@ -3779,6 +3779,7 @@ riscv_emit_int_compare (enum rtx_code *c *op1 = const0_rtx; return; } + gcc_unreachable (); } if (splittable_const_int_operand (*op1, VOIDmode))