From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by sourceware.org (Postfix) with ESMTPS id 300A0384F488 for ; Sun, 19 Nov 2023 05:39:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 300A0384F488 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 300A0384F488 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::632 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700372370; cv=none; b=eMDaLhGtt7XF7VSECjyrstvtb44Hganm3kgwJSYOtahygL3d4Vf9s/aKpul1DB7NNaYODPMnkFBbI9RpD9l1mOYwJ6KBPeBCMp+/dvjiB6t+7OC7FLIBSCYAL28BMeVk0y+QgQhlZ4DEQ2KwqpBBIOBoEvnW1llUwy6NA5puMsg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700372370; c=relaxed/simple; bh=Edv3IW7l78VBn+wvM0/jQBPsKMiGV+HjBSyCSiwBvFA=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=ayNST/AESQno0zaLdScy6XT2XwAM6MEM8Q35K4HRTk126tZccn2HSArxqWg3GRiylznZxrDN6BGQxjNveHa6RIWUyoW5wAgNLo5RIb/fnYwF6UfGLxrUxoBKoowON10+lAzuiW6H9pBefWH6CEWFhR7rPVm93I9WVPcg/lS+QhY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-9becde9ea7bso875659466b.0 for ; Sat, 18 Nov 2023 21:39:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; t=1700372368; x=1700977168; darn=gcc.gnu.org; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YjyTDr1aWa4WyyuQoJ7bfkcBVRchvdrxwgujnLJqEwo=; b=Gyu9U3qPRgYFpDyyZ2Hatx3QYymycDSNru8y8WzalxxE1nQza8G5zcMf5r9eflP11g gLPvx0hxZ48F23HoUDITrq47kdRCBCSHCfZ+IyG4wBYsmZptQOs+AZNfdxyiqjiOPkmq Ps8Y4X+1+mfx/ea+vD1+ekuvbLF4HBSBzvPEAktQMpf5EBTUsh208uYbR11Qg+fsJ8Nl 42fZcsw8CScs/v9szRtEbx3O7Gu5DAcl4ggr8xdvXu/zrRlpFKN7GTmms3dXNPOrwGGG Ln5AqeAI8r18EjTwWmx8ExJMgjl7rLZVDphUABnqOLHmPXWA8rbTb/AQQOUviSw3GjBH dTyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700372368; x=1700977168; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YjyTDr1aWa4WyyuQoJ7bfkcBVRchvdrxwgujnLJqEwo=; b=oxP2ZmvmAs6HHTYcL1L/8LSzmFxgByZiSKImz1nTgeNySf/FuqwciDFDTJZATTQSvR D9EublFOPE+02uVy0icOmEZX6ZaSO1TfDze8hSMNhXj3uJV5mH1OJsLTwclmaxHyCmVl b4Vqr6U2coQeBmXxEpoIPaH8+gDtAJKicaM+iW+6Gw0b+6uzMKedK87nV1FZR5N+Nj+f 9PrLC9Z2f37Ufk50B9SvqhtL2pKL3VrIb2lKWGnh+TFIARU466nta9UA6xfDosStKFVH Rph0AFSor8eYPUlui/KKLRLQchwFvCBG1N8g18OV5RF6tY2ivZbUu473hpJkY0drGHTK ZXsw== X-Gm-Message-State: AOJu0Yx1yEWBJUlIPNsmSfvsqnnoHrcqExORmVfc3U/HzNXM6zVzrEO1 r5EHLOr6oXmiQov2hNxAZZeFNuirEaL84O8iw/y6eA== X-Google-Smtp-Source: AGHT+IGnOQc72JkzEwaEZOSa+XH0WFUispdjJS0z2oQU336z9ROo+7Dv9QO9hpJ5fzKK9U9pSxJSPg== X-Received: by 2002:a17:906:11e:b0:9e5:1db7:3199 with SMTP id 30-20020a170906011e00b009e51db73199mr4085985eje.4.1700372367904; Sat, 18 Nov 2023 21:39:27 -0800 (PST) Received: from [192.168.219.3] ([78.8.192.131]) by smtp.gmail.com with ESMTPSA id bo12-20020a170906d04c00b009d268e3b801sm2543208ejb.37.2023.11.18.21.39.26 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 18 Nov 2023 21:39:27 -0800 (PST) Date: Sun, 19 Nov 2023 05:39:25 +0000 (GMT) From: "Maciej W. Rozycki" To: gcc-patches@gcc.gnu.org cc: Andrew Waterman , Jim Wilson , Kito Cheng , Palmer Dabbelt Subject: [PATCH 21/44] RISC-V: Also accept constants for T-Head cond-move data input operands In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,URIBL_BLACK autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: There is no need for the requirement for conditional-move data input operands to be stricter for T-Head targets than for short forward branch targets and limit them to registers only. They are keyed according to the `sfb_alu_operand' predicate, which lets certain constants through. Such constants are already forced into a register for the `cons' operand in the analogous short forward branch case and we can force them for the `alt' operand and T-Head as well. This enables more opportunities for a branchless sequence to be produced. gcc/ * config/riscv/riscv.cc (riscv_expand_conditional_move): Also accept constants for T-Head data input operands. --- gcc/config/riscv/riscv.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) gcc-riscv-expand-conditional-move-thead-alt.diff Index: gcc/gcc/config/riscv/riscv.cc =================================================================== --- gcc.orig/gcc/config/riscv/riscv.cc +++ gcc/gcc/config/riscv/riscv.cc @@ -4094,8 +4094,6 @@ riscv_expand_conditional_move (rtx dest, if (TARGET_XTHEADCONDMOV && GET_MODE_CLASS (mode) == MODE_INT - && reg_or_0_operand (cons, mode) - && reg_or_0_operand (alt, mode) && (GET_MODE (op) == mode || GET_MODE (op) == E_VOIDmode) && (GET_MODE (op0) == mode || CONST_INT_P (op0)) && (GET_MODE (op1) == mode || CONST_INT_P (op1)) @@ -4113,6 +4111,8 @@ riscv_expand_conditional_move (rtx dest, cases for extensions which are more general than SFB. But does mean we need to force CONS into a register at this point. */ cons = force_reg (mode, cons); + /* With XTheadCondMov we need to force ALT into a register too. */ + alt = force_reg (mode, alt); emit_insn (gen_rtx_SET (dest, gen_rtx_IF_THEN_ELSE (mode, cond, cons, alt))); return true;