From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by sourceware.org (Postfix) with ESMTPS id 1CDA23858C29 for ; Wed, 22 Nov 2023 02:13:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1CDA23858C29 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1CDA23858C29 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::52b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700619197; cv=none; b=YSd8DA8n3cM5DDnvY6A0NFbYVjYY3H48CQGtHvry+73kYGRG9i8ukrNs9NNDRWY5IazpwiQy/hOQ7T38XZJKjicMV5KYsbhSnqhjKmswZnHSxh38FT/BCrs3NXww24/6FXhhe+53PANdvjX4Tb3N3TZ9SQ0uJ3qum+DlMyuYuKE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700619197; c=relaxed/simple; bh=EexXrB2ekjx2KnZTtD2bEyU5ic0Tf54yrYY41uZWKa8=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=eEw0ZKcU2UN8Im6ETULSi9PTEJBL6YatI3q3yGAeQEGLgBCfdn36DYHqzq9NioDgJr9DCgXXvFplATl7QzwiM+6Q8dO21uxhIr9KwWpcV/mf5yn/DKiPb3FSaDPx3HRIIgKQ5AzTsjKoCk7F7vZc54Ligg4R/LoY3SeKdg92cGE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-5482df11e73so7021409a12.0 for ; Tue, 21 Nov 2023 18:13:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; t=1700619193; x=1701223993; darn=gcc.gnu.org; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0Yp3g1dRigiDvI69V4X0tXpSoBbflauuqyKjFm8zOXk=; b=Frj7x+lKhoZN7YpedmZOzMZeUXT5e+XrPLgGG47YdmR2tNeEJJwkW/74JvQB9pynDn H0W6QK64g4tzfGOd1c8vOqIyJL9LHUqFQ2HYRyuO8TbvxkSXj/0hNxRhhoKwzKPKXRYr g2fR73KYD+RGgc+qITKgOS7DIyydmreqqqJwWmbXmn/qorFCAhZhBWJkPm/oyrk4Vxdp pwXzydbVoMOHTMtdmarAV1i5ud7XcUlx2nWtD+TrrAaXVKM1SYnBNSojYBXC71Sn4swW d3P+UujxCWcjCV5rcLzZ+pSxtArTiWUU6Efj57j5iOeOph1ffR2PLOJzrWjXU9A/tXhN oD6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700619193; x=1701223993; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0Yp3g1dRigiDvI69V4X0tXpSoBbflauuqyKjFm8zOXk=; b=i05CUBpYTkzelQGmjxjuUSyMCxGKuFBpuCEatIsiGPwQzdUfz1HxsT9PuJhZrQ66bU /jcvPrn1W4fRtiX1bV9Tg+8HqL7KG4GcTcGk7mvb9nsA02GeHUGWlyNPIFAdABeMEBfr 3jUUj78Gv+LyA4j3CyX0mybNI9nOrT2I3leTLuFG80bSph9O63va/TCXRn1NAuL0oBly W3gE9W0wTsmmBMQJx+/SDRckwlwzDB/AY9YMUE4cfHRBDbcIrvo/rvrZeATohXNXXGWC WzFvDs/7vtbfrXer0KSejup4Py3WRhANZGy+T8SHhFisel1f8e6w1h2kmYgk8Fhs1vhh Qo4g== X-Gm-Message-State: AOJu0Yx4Fli5vYvzFuEFYN5tHJde1NcThvlZFsTnafqSfKB+wbtzP87Z I7Zp5pK+4OyfoYtIcSntHzX68Q== X-Google-Smtp-Source: AGHT+IETn/EBPj5TbX/YDIicq7lcL4ADrqo4F5ZoItyQ0p24WOTnmtfsAIaF0bJxGnlfGsb2hgUVxw== X-Received: by 2002:a17:906:5195:b0:a03:d8ea:a269 with SMTP id y21-20020a170906519500b00a03d8eaa269mr461807ejk.11.1700619193689; Tue, 21 Nov 2023 18:13:13 -0800 (PST) Received: from [192.168.219.3] ([78.8.192.131]) by smtp.gmail.com with ESMTPSA id cm41-20020a170906f5a900b009e505954becsm4703801ejd.107.2023.11.21.18.13.12 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Nov 2023 18:13:13 -0800 (PST) Date: Wed, 22 Nov 2023 02:13:10 +0000 (GMT) From: "Maciej W. Rozycki" To: Jeff Law cc: gcc-patches@gcc.gnu.org, Rainer Orth , Mike Stump Subject: Re: [PATCH] testsuite: Fix subexpressions with `scan-assembler-times' In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, 19 Nov 2023, Jeff Law wrote: > > Verified with the `riscv64-linux-gnu' target and the C language > > testsuite. OK to apply? > Not sure why it is the way it is -- I walked back to Zdenek's change which > introduced the scan-assembler-times and nothing about the -inline argument. I went through our history beforehand too and found nothing interesting either. My only suspicion has been it may have happened as a conseqence of somewhat confusing regexp(n) TCL documentation just saying: "Determines whether the regular expression exp matches part or all of string and returns 1 if it does, 0 if it does not, unless -inline is specified (see below)." and then you need to dive into the description of `-all' to find out it actually returns the number of matches rather than just 1 or 0: "Causes the regular expression to be matched as many times as possible in the string, returning the total number of matches found." I guess maybe Zdenek missed the part after the comma? > OK, but be on the lookout for scan-asm problems on other targets over the next > few days. Good point. I have grepped our testsuite for instances and found only one (as opposed to numerous non-captured subexpressions), specifically gcc/testsuite/gcc.target/arm/pr53447-5.c, well-documented as working around the quirk. I've posted a change to avoid the quirk with this case: and I mean to apply it just before this `scan-assembler-times' fix. Maciej