From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by sourceware.org (Postfix) with ESMTPS id 6778B3858D35 for ; Wed, 22 Nov 2023 01:37:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6778B3858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6778B3858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::630 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700617031; cv=none; b=v2EW8B9FnVNAAZsx5S71o3wuDLwQAhpR3r1yOHbF85K1vGYqhr5UZCYfaCSEKnL72ssdl5WksjTF+O9wqVPobun0RveHAI2018B2qHUvpfWEjMerFgkS1WIhjOx/lxwdO4ZpLrb+03gMjm/7J/UV1Sasnf8m6p4J0ccVWVzgmMM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700617031; c=relaxed/simple; bh=ljOkn3enlxGL6m/djdNj1sJq/Dqu/9owQI968IxZhgY=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=SUE93Nch6GgWn6Sg30gz4d1ZTp9QkqW4mUbnHGoTq+NVeJHCF/lC8HS15a0nqHlNU2NjrjUI3lLCGg+dAvuxqAeLIeBNWHMG9P54I3SDiJYrarPqyaOdEco3HNabeg2dxju4tXUffAO5WT3Y6FMLuTfr2ByLJ/7n8Bm3exP6AFI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-9fcfd2a069aso426488566b.1 for ; Tue, 21 Nov 2023 17:37:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; t=1700617028; x=1701221828; darn=gcc.gnu.org; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=FFYbI3gR4xJAPz9SFZsUmRl5ZWrHX1VHhcmOy3Dh/zY=; b=fYCYcESh2Xa79rWKt/a57xgSQPZ/lc9WOGwn8XTaW2WsFmI3eUtegNbNECchWPUEuo Xyq4NZ7hHZXsTy1/kBVN3atRRyS9l0YdBnwZIF71H+cofTvKW5ZYOepycM9W2WFhqY/1 BLwWymzprro1LfNqEe9H8cxDyq5WeZMg2phjALyZzu/ViK91c88byCJdGVxm9Q8LZnxz V43WhkxP0xve6oPDH0w68KLdLhZRC+iR7hBh0yGBY/YnGMHNh5QDliCzx8xy826gSNfC yoykXvCUMi6VwQcw1+XymZUuBkcOVEr5LJ2oFO9LKRH8QdxRGENiLTHqmc+GiZWDlnb0 YHWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700617028; x=1701221828; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FFYbI3gR4xJAPz9SFZsUmRl5ZWrHX1VHhcmOy3Dh/zY=; b=u8LcVmNV/xMnv8c4pVUzLNsifvavXXAmxIs/5NBLEDjW/rW80ObBCnBG8T7Ua9DdlN yNRoHeO3Y3sH3KS+bHqH8cihKBucDB7vxm1hZc98ZZ9+rUMvzucHIQ0ci+LMOggNoDty gFaq3P+i3eot9IFr9LSh1ZBwWQIulVs0n8xiFThdjM51mSTnWfhJ+t5ZclpzAD6W/blE 3Y4FMxWuIQVjkCByrPWlIcnIpgN0XkHFTHnCHyThfPGmOc2WjAQ9RBlCVmWBlvIp6D7F NZETLJWjoRmIuN+YLKtyhRaR1qLd3scoqmPXaym/vfDC/R4dFaRB1xngTlswEIoODxta 0ILQ== X-Gm-Message-State: AOJu0Yy/uWyb1DQzej51M6dDnJB6kz/ec1Y0h1VTpdVwrRHb9+VlJts6 7HUJlchPjCNlt8KZNkPsNw0wIg== X-Google-Smtp-Source: AGHT+IFNTHvNdrT0Y0pZ54lbZ0O/K1KWTBqyVr2q4Xp+mQGF/ACzLKBcDUXiLTDaD0l2WtmdaUB/zA== X-Received: by 2002:a17:907:d38a:b0:9c7:59d1:b2ce with SMTP id vh10-20020a170907d38a00b009c759d1b2cemr519924ejc.5.1700617027964; Tue, 21 Nov 2023 17:37:07 -0800 (PST) Received: from [192.168.219.3] ([78.8.192.131]) by smtp.gmail.com with ESMTPSA id e7-20020a1709062c0700b0099d804da2e9sm5921479ejh.225.2023.11.21.17.37.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Nov 2023 17:37:07 -0800 (PST) Date: Wed, 22 Nov 2023 01:37:05 +0000 (GMT) From: "Maciej W. Rozycki" To: Jeff Law cc: gcc-patches@gcc.gnu.org, Andrew Waterman , Jim Wilson , Kito Cheng , Palmer Dabbelt Subject: Re: [PATCH 40/44] RISC-V: Handle FP NE operator via inversion in cond-operation expansion In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, 19 Nov 2023, Jeff Law wrote: > > gcc/ > > * config/riscv/riscv-protos.h (riscv_expand_float_scc): Add > > `invert_ptr' parameter. > > * config/riscv/riscv.cc (riscv_emit_float_compare): Add NE > > inversion handling. > > (riscv_expand_float_scc): Pass `invert_ptr' through to > > `riscv_emit_float_compare'. > > (riscv_expand_conditional_move): Pass `&invert' to > > `riscv_expand_float_scc'. > > * config/riscv/riscv.md (addcc): Likewise. > This and the rest of the patches (41, 42, 43, 44) in this series are OK. I have committed the whole patch set now, thank you for your review. I'll address the concerns raised in the course separately. Maciej