From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by sourceware.org (Postfix) with ESMTPS id D193A3857BAC for ; Thu, 23 Nov 2023 22:36:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D193A3857BAC Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D193A3857BAC Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::532 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700779021; cv=none; b=Ogb41uVMYaK9M48/8lqf4yxO4/OEQi5AG0PdNvAkGyt2QghzzGDVp++qLJLgwI5XWpZAnONA/sZW6lo2Md/m1/bN3qT6S8do24e+Yr0yQQNX02wg/+PDY4lJusoiXFLfXzhzsDAkrS4p4CWLAjKSkFmJ4xAZqBF/6ZEWGrEEjyw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700779021; c=relaxed/simple; bh=4cuFG4+R/0oENM+iFustC9mo4iu/b8L5a/HhmtjSNeM=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=Xtor6SNn40J1hAkcela6Uw8h6/VWTeV/FyxC2TjPSiI54KBuGQqV9MfnrVm+Dl/45TSAdGmc79YCL2QJXCxCfIjhM7WNaheISG75Xrql5INbR0Y8AFs1FwxMYk+dmCthPBXZFR+NlJP1l99EVxdKAxMxfPcjoK8baf0S2TT2Zc8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-54af1daf6a9so116028a12.1 for ; Thu, 23 Nov 2023 14:36:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; t=1700779005; x=1701383805; darn=gcc.gnu.org; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=kMW77Rxco7Hrmz0G6Lqm5QrG/FT10FO0tue7mdQEoqg=; b=DsFL5uJdoYyrxtJtJnm7U+2ZZmDAIRpWBR7uf+CWWq3fGBzwu1hlJ3LZgTvU/6faod 9X+jcSl1W+fjtC0Lzsrv3l2qVq7mDk58Psh5IRrAf61fpG3iy7yUZ0DEUjJyMn9RhJeI d5N6bYOvdXH7ahlG3aduYjNkquAELec21SVgu5jFQNmzSbfyhtYpGAEv7QRPJNF80nKI 8/svujwoC4LVddUTsw0IeeZwdPipYcxjaY+qaLN6SJ0VnOBOKGJnG/6zhjrED7a1n1Sb lpbjXcbnCMngDS2qWVjOT2sxQ72u6S/HbYxz8tXIHgDwespnFZeM9rwHA6kf3kbbz4oK AK4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700779005; x=1701383805; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kMW77Rxco7Hrmz0G6Lqm5QrG/FT10FO0tue7mdQEoqg=; b=n1bbkNvPjcTpOPTzx3wINZ2jJpXssB6fRASnQRHw5USrLz33Hs5nLRgLqUhtObDyDU VUYeKmlHNdyEZhnL4G28yUHkatFPP5kcCDiZPhalgVH+7peX9khPHdrzO+Ckym/3PDzp OEiY5pAFMVv/BwnOgzVq65Sq0c6f+3oBIvThLL5R9xmznW13swx73upcF6tQCZEGXA0g seXbr/WVOsJ/XdItO/JUAqmUKRkFuhBgKVQkhCjiFxlBc5xrIVYcGCXO7/w/BcC9jdyb oIvUHJDEAccWxHH/yfCK9Lz/amhbbeGVZ6nU2dTDSx85LvF8QSgWTN8Dw63H+T7QiiHF d/7Q== X-Gm-Message-State: AOJu0YyNcFZOQWNvgC20PM0ludOSgWYzFgkBOo14OVwZ4HmtEszr1ArS LHayhVyrZlxsMfim8CSxXbEUEw== X-Google-Smtp-Source: AGHT+IE9vjUTCaD381PsKTG5flc74DJJ031x/AXLWzbbH+m6qLNgem4YEiHdBi5i/RgC8PtFQzvWrQ== X-Received: by 2002:a05:6402:641:b0:549:441:8421 with SMTP id u1-20020a056402064100b0054904418421mr3730493edx.12.1700779005414; Thu, 23 Nov 2023 14:36:45 -0800 (PST) Received: from [192.168.219.3] ([78.8.192.131]) by smtp.gmail.com with ESMTPSA id m24-20020a50ef18000000b005488b4e9dbdsm1094434eds.50.2023.11.23.14.36.43 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Nov 2023 14:36:44 -0800 (PST) Date: Thu, 23 Nov 2023 22:36:41 +0000 (GMT) From: "Maciej W. Rozycki" To: Jeff Law cc: gcc-patches@gcc.gnu.org, Andrew Waterman , Jim Wilson , Kito Cheng , Palmer Dabbelt Subject: Re: [PATCH 29/44] RISC-V: Add `addMODEcc' implementation for generic targets In-Reply-To: <401c1684-7ae4-40e5-ad7f-aab595e4a47a@gmail.com> Message-ID: References: <401c1684-7ae4-40e5-ad7f-aab595e4a47a@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, 19 Nov 2023, Jeff Law wrote: > Is this an improvement over what if-convert creates for a conditional add or > is the goal to expose the sequence earlier in the pipeline rather than waiting > for ifcvt? TBH I haven't ever seen if-convert eliminate a branch here without this pattern supplied. Maybe I've missed something in my previous evaluation, but building a representative subset of the add*.c test cases from this patch series without the `-mmovcc' option seems to confirm my observation, so I consider it a new feature rather than just an improvement. This is also why in the cover letter I suggested that we may consider moving this optimisation into if-convert proper later on, to benefit other targets. Maciej