From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id D10B03858D33 for ; Thu, 23 Nov 2023 22:48:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D10B03858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D10B03858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::62b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700779718; cv=none; b=WTyvRqWKya2KSgRZ7Qf6FT9C0dz1vNFkrV9UOY0n/HQCnsrXCSXqZL/apSQFGSHXpDhQPE4Kw0bwZgCz38rxLNhYH5Q4NZ0iwb3uJbLETwdaIIhYwNLgHoPt+83Jzzm9U4TPetfFWzYX6tU4yfdtPtcJBt7SLLOiIAk6EFXGvYA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700779718; c=relaxed/simple; bh=XDyV0P6H1QUqvYZJJmp4O+uWyWbtB+E+Jyp8bbVbNhc=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=hzfZZhNcFHgT9yRAgo1cBhIBjn8RejLo9yKfRZrwFs7m5sbEjOpoTLXe/ucYKumKEL9Mk05Faq4z/209XTSR0QwSq/Fp58xhR89XUXFHFe3anvy4e8r06kscYmvj61SHbjNupz3QZka8zbtRYciBgwzYXi2lNZd84SYFFxdtJXw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-a013d22effcso174695266b.2 for ; Thu, 23 Nov 2023 14:48:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; t=1700779714; x=1701384514; darn=gcc.gnu.org; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MF0ohYf+PXPgg2y/BP+Cxkq9wt5mRaEGyFuBtSHEGl4=; b=NxSvUkc9cUfeUdXG4GT1sG2fTs/mHN21kIJfjwEK8a1I1dfBIwUxjqqBnfCwJHDHgD w3eSZ+bsGo4owaD1b0dMSJ0/axitFWetI8v5lqm9ZfN0iXgdZkLQYl0rZhmBel/FUVBz QNunh3zyA4IeH+iCvCGiTJqnUSEGYBw8IJqc613moa/BRZUwkv9bTy9vV5TH2DewVvmu 4SDj345wyyUFz2KtGxB191IqXBOi8w+YIFTq00cCX5gk0EMOA7h49p6mEsEkORPuPN64 x8QwwccU46KlbkKrpGLeUubzDN3rde0tHEkC4JiyI0qLFlDuagWQL+1v4TAIyGLaBTvd VXMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700779714; x=1701384514; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MF0ohYf+PXPgg2y/BP+Cxkq9wt5mRaEGyFuBtSHEGl4=; b=kNLTtNWzmREMx4uiYg+dU7jHbA8IpCu5iWSav3USH/0tjaQSMC+UjV9eIyvZzM480c BisVYvXrWg5dRYkhwF5+oEXxaeGT9Zn/nijgdPoBasaECevGtoy0w0OMYNCpgv3mmm4G xInjPgsvekJJih4fj0LNgX6WSI8JY72mI41aF+iEZwvscimuadOkFCen0+ivFnARs3jL V0fDEbuq0oi/XDPKDYZY/ZXpFNrDi9nNYOo6+1AiK6UJAx5MQoqwan9Djux4/5m+V1P8 omDjF51Gdql7aqZBNECbvKf0qXi9gYB/ck9i7hQcZuHRYtEVwOHRe4ilCZvJxrcdUC20 Bu5A== X-Gm-Message-State: AOJu0YwW6U1j81TsnLqlzf+6fFzB6lWLZ+dz7xB+CKq1XcY9tILIoJcX Zgi50QTjoVyC/VCAegqwkfvA1Q== X-Google-Smtp-Source: AGHT+IEWwV7Ownz4jYiTfLoeCdqbKrHz0DCkIM3r/NMaZsAPi3M0GSiEUYEDWDZ6r9Gwb0EZI7WtMQ== X-Received: by 2002:a17:906:2088:b0:9ff:911:f38b with SMTP id 8-20020a170906208800b009ff0911f38bmr543528ejq.48.1700779713941; Thu, 23 Nov 2023 14:48:33 -0800 (PST) Received: from [192.168.219.3] ([78.8.192.131]) by smtp.gmail.com with ESMTPSA id ga10-20020a170906b84a00b009fd0102f71asm1280578ejb.176.2023.11.23.14.48.32 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Nov 2023 14:48:33 -0800 (PST) Date: Thu, 23 Nov 2023 22:48:31 +0000 (GMT) From: "Maciej W. Rozycki" To: Jeff Law cc: gcc-patches@gcc.gnu.org, Andrew Waterman , Jim Wilson , Kito Cheng , Palmer Dabbelt Subject: Re: [PATCH 31/44] RISC-V/testsuite: Add branchless cases for generic integer cond adds In-Reply-To: <35a621ce-88dc-461e-86d4-bbd1e39f805c@gmail.com> Message-ID: References: <35a621ce-88dc-461e-86d4-bbd1e39f805c@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, 19 Nov 2023, Jeff Law wrote: > > The reason to XFAIL SImode tests for RV64 targets is the compiler thinks > > it has to sign-extend addends, which causes if-conversion to give up. > WRT extension and causing if-conversion to give up. Yes, it's a real issue. > In fact when we had Jivan do some analysis work on missed if-conversions, > better handling of 32bit operations on rv64 was the biggest class of missed > cases. I have been aware of the issue with extraneous sign-extensions (and how our difference from the MIPS ISA makes it a problem in the first place), as I fixed some myself in the past and I do remember them being discussed at our weekly meetings as well, so I've decided the best course of action here will be this kind of test coverage. > We've got a bit of internal code to address that. But I've been having > trouble finding the time to clean it up enough to post. Which will hopefully show up nicely as a bunch of XPASS results across these test cases once you do. Maciej