From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by sourceware.org (Postfix) with ESMTPS id 4D66C3858D33 for ; Thu, 23 Nov 2023 22:55:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4D66C3858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4D66C3858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::62e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700780130; cv=none; b=cd9jim++Wvw26s4HISL5IpxdLJMr/nGBiqgB6yNHupKM1aaIhI+sU2E7ssODv8LMlUh/96JIyweotemqhZZ4/lqNyHuJ4o3IDf9CYQQKpK0JKbsxLCYe5WlA4EphZQryfOfncWhU31ybLPHs5dJqMAQv8GOrhCDRutfCTcIR10w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700780130; c=relaxed/simple; bh=/Lp+ys1CFNh42mcS5GpE+yBIpRuq61Np8PAaC3PJ0/g=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=mSheIjVERRInaTkG7FnHnW30EwT/3dgR3m6kNp437XxUzrZmE2QxsNM4TTqdjJLuvozJ2NPIK9Zkai8TA1chCMcP9D8POmLJRQ/zwBg+3jCgz+G+ZKhToyJu4SivBdraUxxUzgGumpRJJt2awcqeX9ZEuxYNEks6MyXl33++1V8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-a02c48a0420so180263066b.2 for ; Thu, 23 Nov 2023 14:55:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; t=1700780128; x=1701384928; darn=gcc.gnu.org; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dykj+UMKB5vAMnPM0ExWX5RIbdTWN1jlVZ1aRcAQKzM=; b=hEiVsz8+lk4qOXbNirq+t86URIZz/Rdn/CWyD8lDXkoaAUXAdLstVNKhW3uLmd+a4U zlBV9890UoNZ4jmrn3RpkuRPK9b7e4yPQu9qNPh2BAgd9L0eXcEqHCY0le4Zt3gUVDSg WxwJyOZLPB9VHZbK3mjbhZRbtBVNUgwk1cgW5HbEC2Uy0c3cBX+O/mS2aayVI6MhZ8dd 0BeXCmsXMyf6R7Tz1BGUoa7/io1F0I0J+unZ3kW5ar3QoENO2/EZSXLX0lUJNOXXVtzM 6QpBddm+AHrEsrmyE29ZycXAboeMSzlm0Gvi7sv+BkOgNGNzXzhW7NM3/20m0Pwalh44 iyhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700780128; x=1701384928; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dykj+UMKB5vAMnPM0ExWX5RIbdTWN1jlVZ1aRcAQKzM=; b=wj6Pi6GSSLxnTUfN02IiHv4UyFbZV87scyS0IihoSt60FgYndo+1d635/e+IARkXke AGf5duqasKoRYZWq8WGS2/o+00Q8LWBf+dtkgCqmIlqYc9zaRzW+GwXg09l0Jw8Hbc8Y U92pvxA5A17nf8189OTiyF4A9NQXE5z/GyTPpth94+iDPUQjyX8QWKfyzaXKXB98mxKc ejiE5FIGNuXRWaAHQk33BFMjPKEVH6LSTlN7Obc8AER1gtWZRwy0o1kWi1hF6EtaQMKM TICqDKKIwmqnyqf6VhtHNDIrnv4/MIuO8r93KSPbiE1cpxgrDzjG2+1a47AHbZU7b8YA PIKw== X-Gm-Message-State: AOJu0YxkOBeIQZlSZEEjzqStasgfD3aLn9OTBLmCMXHnWKj6icPkzxs7 xzfN4N6d/u/P/DRDyv25Ahu3Lw== X-Google-Smtp-Source: AGHT+IH5XT3tbwFhOEZMvKw1/5Ov0nTo9eAXPQstVuBRMBxbAmWsspf4Nuw8bYkTF6A/dV58QbyXug== X-Received: by 2002:a17:906:b6c3:b0:9fc:fe5d:1e25 with SMTP id ec3-20020a170906b6c300b009fcfe5d1e25mr455758ejb.74.1700780127922; Thu, 23 Nov 2023 14:55:27 -0800 (PST) Received: from [192.168.219.3] ([78.8.192.131]) by smtp.gmail.com with ESMTPSA id q22-20020a1709064c9600b009ae69c303aasm1276751eju.137.2023.11.23.14.55.26 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Nov 2023 14:55:27 -0800 (PST) Date: Thu, 23 Nov 2023 22:55:24 +0000 (GMT) From: "Maciej W. Rozycki" To: Jeff Law cc: gcc-patches@gcc.gnu.org, Andrew Waterman , Jim Wilson , Kito Cheng , Palmer Dabbelt Subject: Re: [PATCH 33/44] RISC-V: Also allow FP conditions in `riscv_expand_conditional_move' In-Reply-To: <099bf26c-aed4-4f8a-bf15-4e3f71165dfb@gmail.com> Message-ID: References: <099bf26c-aed4-4f8a-bf15-4e3f71165dfb@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, 19 Nov 2023, Jeff Law wrote: > > Lift this restriction and only bail out if a non-word-mode integer > > condition has been requested, as we cannot handle this specific case > > owing to machine instruction set restriction. We already take care of > > the non-integer, non-floating-point case later on. > > > > gcc/ > > * config/riscv/riscv.cc (riscv_expand_conditional_move): Don't > > bail out in floating-point conditions. > I probably goof'd something when merging up the eswin, vrull and ventana > changes in this space. I recall fixing multiple bugs in handling FP > conditional moves when building/testing spec2017 internally -- so this was > supposed to be working. This didn't matter though, because before 34/44 FP conditions could never make it here, not at least with pristine upstream code. Maciej