From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by sourceware.org (Postfix) with ESMTPS id 3D1C93858031 for ; Thu, 23 Nov 2023 23:26:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3D1C93858031 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3D1C93858031 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::532 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700782000; cv=none; b=wMTo32vY2GOzqjozVeGQuWkHTOuvgwNP8FASiZwWO2BHJ5ri1PamEhbtSytiwwk/dmnZg4G0/eJZWzxQe7bc+kyPkhzBicHyRIRP1Ia03bgKnQkz5+MATUoOMjZ20dGoyigbpvKZewZH+fTtVhyTi03SqcZG+OHKmrLlK7GfGu0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700782000; c=relaxed/simple; bh=YKmYaWH+LiYIsupkLIV1ChOL8UEylmOsG/kUjpPgC18=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=Oy1DxyooFEVWjH0lM0aiekhDs8SpQ3jJLctdGod6ptX7RcZXoYSgnE0zEP2D0MBqhf/okMvsv9ZwxP5Kne504ry+pSXbCAMRpAYEDqsHeTqTMXrKURetHdXCZv+rLHT6XXtmbXKaj7AYpIaBHBUzysmx9fp22AN0uMh8FMBbuPY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-54acdd65c88so502324a12.2 for ; Thu, 23 Nov 2023 15:26:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; t=1700781998; x=1701386798; darn=gcc.gnu.org; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ZSwO2hZjk5BySHVywyTrz8mAQJ9tVyU39cF0GHxAFho=; b=hWo7N/rFlt/sTSvFThyvM95ZeOIVbWTZY/DSINF/92xPGZzXyBt238AR05fQU8t4t8 ngCwCy8ldxy9db79NqDDe+N80aak5ZliuqFpyzUDFtHa1Vc29dQTnwAzbx5wQvHkO9Db E44hJGftkRMAzeLsaEoo6PfSYu2b7F+MsZEPkwEL4USOtO24x0I+NmW57NEbphHFjRB4 AEr61fYYaWf8Jc/IDfgi1yhQ2ySX4/4WpqhpJsQecFb5V8QAJQ3xfo1W7fcMZH9ilntH qmY7AtGRCFhFkeKgSgatdasg+NM9NeRtKHbqSlDtr5aDsUpfeZR7aqNySENbsXsHaVa/ g39g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700781998; x=1701386798; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZSwO2hZjk5BySHVywyTrz8mAQJ9tVyU39cF0GHxAFho=; b=w3fP4Z+FiX3eucbUYhHMfnqSAuWfiIiB7LGRY0ydKjR7AGXzKIoBotkY4+FjCDO0oZ ruWP6Vyqrra/58PWXn4EVcaz1Z92/W9zIR0dF0wShpnyPLdf/e1sWBZ0i3RmI1CQFVuZ I8A6Ls3cjjbkQ98htCfUm+bgn+bYvHQskOjcrUdQi3Bk7l6QPCkefoSUdcSDpqDsGGi5 HtIrxwNuUi7ORz6Rki9f3zpBBz/mmd3VkT5ZOn0ZAQ4D52ZXJdLkIj8ctQPnPA3TuItL /lDPoKCBYtZ1iUGF0zzAA5vuUA2P3/+Ed5P4e/kqykndwT+tBka95P87clXY5XUBDvHC gmIg== X-Gm-Message-State: AOJu0Yy18E7e1QKPqRdkWd0bTH4BPGBjyVCROGQXJNsbsVvyY1jLZ4Lq L+872O3x2hGBN0SQTeNiTjqAew== X-Google-Smtp-Source: AGHT+IEkWTUpUxJO0Re7DXQjZ6L5DDavCw5ksOX6asc8LpWSnKmNN7i/IoKiJgFEMEs356oHTV1QRQ== X-Received: by 2002:a50:d715:0:b0:54a:8e41:cd06 with SMTP id t21-20020a50d715000000b0054a8e41cd06mr515688edi.2.1700781998049; Thu, 23 Nov 2023 15:26:38 -0800 (PST) Received: from [192.168.219.3] ([78.8.192.131]) by smtp.gmail.com with ESMTPSA id j26-20020aa7ca5a000000b00548aeeb1a9esm1110344edt.89.2023.11.23.15.26.36 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Nov 2023 15:26:37 -0800 (PST) Date: Thu, 23 Nov 2023 23:26:34 +0000 (GMT) From: "Maciej W. Rozycki" To: Jeff Law cc: gcc-patches@gcc.gnu.org, Andrew Waterman , Jim Wilson , Kito Cheng , Palmer Dabbelt Subject: Re: [PATCH 34/44] RISC-V: Provide FP conditional-branch instructions for if-conversion In-Reply-To: <6c95d298-a854-4976-bc31-830b9e1cde09@gmail.com> Message-ID: References: <6c95d298-a854-4976-bc31-830b9e1cde09@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, 19 Nov 2023, Jeff Law wrote: > So this is a more gradual lowering of the FP branches to allow ifcvt to do a > better job. Seems generally reasonable. I don't expect that we're missing > any significant simplifications, though I probably could construct a missed > CSE/GCSE if I worked at it for a bit. I've been thinking about it a little before submitting this patch in its final form. I considered activating the splitter in split1 rather than split2, but figured out it would likely make little if any difference. We could add another, yet earlier split pass I suppose, somewhere between ce1 and cse2. I'm not sure it would be worth it though. > Presumably the length computation can't be handled by the generic code we've > already got in place? I disregarded such an option right away at the time of writing this code. I'm sure this code could be folded, but not in a straightforward way. Notice the different, misaligned branch spans, owing to the machine branch instruction being the second in the ultimate instruction pair produced. So getting rid of this extra code may not be worth the complication in the common "length" attribute value calculation unless, perhaps, we factor the branch case out to a C++ function. Maciej