From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by sourceware.org (Postfix) with ESMTPS id 6CD763858C62 for ; Wed, 3 Jan 2024 16:38:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6CD763858C62 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6CD763858C62 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::532 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704299912; cv=none; b=XRleg3VbsBwF5qCGkZMWwdV0jIZ+o5gylXqCYNyE8eE+AyAE4BjQ0UGuckKrb5PhBBZlqYMWkarkYnVXBW2LihpbhUbYDXKkdyMAvr10/iAofHYCF+g4xdgc7dYUnplcWryZsircYz7hGhmd6JRGTKQG6G1YlJOd+evfs7bKdWY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704299912; c=relaxed/simple; bh=tZFKpD1qpQEYm7jjNyFNEr726xxVyFhja5V4vFwnSLw=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=rFmG48l5hjoaZHLvVABieVYmnjsqQB/IzRBBRpi+d4MKBEvg1Tn8JnolGfJh3+x52XQcXNUjr69SABCSgEAIV+/04v5o543m4a2jKlRim4WIalz5T2NFsZy4iqvJNnFj9N3RfXp/uoMdHoS7SVUIJWrt8Oi0qDdUfvVmrT+rNyI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-556275957ccso3031603a12.0 for ; Wed, 03 Jan 2024 08:38:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; t=1704299909; x=1704904709; darn=gcc.gnu.org; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1dzN6HeTnahjU4rwdnxDZKyX0xOzQags5glz+bE7oxA=; b=a9cB7FdIL6ID01Qw8QasrgbY8FkKMtxbB/iV0eVRLYJfrstkXYE057WX59merrf1AD IQ1xI/kIfi6gnzMbvd5hDXwyg9fw9IW7EaUTpIs2TawXoaC26WAGORKLCbCtTY7pdpC7 qIxPZE8QV7GzixXToqKcgO7m0ohuXqAwoQA8Rs31ih0pS9RQZC5qfOog7NKsFGphZD2p SGVifNWHvnrQ9up7+XETSFUCJW4BRVsUiLwj2dWGri5cINw/iUcd1meIlSzRtRjq3C5m cu0Cr5Bvhqf7Iy2R5FOGN8K9kXe7VMKdToYPU1EFcseWpblPAvfCNyCPtjUm/5FvRZ9u 7gQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704299909; x=1704904709; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1dzN6HeTnahjU4rwdnxDZKyX0xOzQags5glz+bE7oxA=; b=F/cpjPIl2SgXoh/b9poH8kDBqsz+pfZCChsKwrJ6YSP3g1BduzZ04MYszjk0bsJvv/ 9GcqD5WmtU5Bv+AUKAcaJsWp2jnbbbWRKkQMoi5WgW5M5xbv0GK2NnnTmrcHv8Xnc170 FBnfjt72srvAgf4PH3E37WCF4nJ7VZvZ7pdEjP2RoZuQ5K685Y/rBhp1xaOTmJpUEho/ 5ABEQa8ekplZQJoMU2EIenbMW/ZUQWAOPxupnGY4GnR9ZQlL1g2Y1Gt9tdLQdbOlU6qT InpblpHBFLo2ovHpWXfwt7niEtV+UMKqobb6k10mKayldg59ekMYtEXrtyf2jdvRgT/M 9lSw== X-Gm-Message-State: AOJu0Yw9XeDzO2wSTrayTAyh0+1hGgvhwtwuzaLj8lYBDldy9E6LMhvP ITBdFTwRqNVVoPmdSc6PlbdzSeXWYAdkkA== X-Google-Smtp-Source: AGHT+IFIWls+tsKgdB3RdMiZDtigkGjnjMz/xdIZsUl+OQcmH1usSlbFAgAY74o2LcgeUvHwV7vICw== X-Received: by 2002:a17:906:3bd6:b0:a28:301:4637 with SMTP id v22-20020a1709063bd600b00a2803014637mr1271946ejf.202.1704299909024; Wed, 03 Jan 2024 08:38:29 -0800 (PST) Received: from [192.168.219.3] ([78.8.192.131]) by smtp.gmail.com with ESMTPSA id p13-20020a170907910d00b00a26a63346ddsm12440004ejq.87.2024.01.03.08.38.27 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Jan 2024 08:38:28 -0800 (PST) Date: Wed, 3 Jan 2024 16:38:26 +0000 (GMT) From: "Maciej W. Rozycki" To: Hans-Peter Nilsson cc: dejagnu@gnu.org, gcc-patches@gcc.gnu.org Subject: Re: [PATCH DejaGNU/GCC 0/1] Support per-test execution timeout factor In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 3 Jan 2024, Hans-Peter Nilsson wrote: > > The test execution timeout is different from the tool execution timeout > > where it is GCC execution that is being guarded against taking excessive > > amount of time on the test host rather than the resulting test case > > executable run on the target afterwards, as concerned here. GCC already > > has a `dg-timeout-factor' setting for the tool execution timeout, but has > > no means to increase the test execution timeout. The GCC side of these > > changes adds a corresponding `dg-test-timeout-factor' setting. > > Hmm. I think it would be more correct to emphasize that the > existing dg-timeout-factor affects both the tool execution *and* > the test execution, whereas your new dg-test-timeout-factor only > affects the test execution. (And still measured on the host.) Not really, `dg-timeout-factor' is only applied to tool execution and it doesn't affect test execution. Timeout value reporting used to be limited in DejaGNU, but you can enable it easily now by adding the DejaGNU patch series referred in the cover letter and see that `dg-timeout-factor' is ignored for test execution. > Usually the compilation time is close to 0, so is this based on > an actual need more than an itchy "wart"? > > Or did I miss something? Compilation is usually quite fast, but this is not always the case. If you look at the tests that do use `dg-timeout-factor' in GCC, and some commits that added the setting, then you ought to find actual use cases. I saw at least one such a test that takes an awful lot of time here on a reasonably fast host machine and still passes where GCC has been built with optimisation enabled, but does time out in the compilation phase if the compiler has been built at -O0 for debugging purposes. I'd have to chase it though if you couldn't find it as I haven't written the name down. So yes, `dg-timeout-factor' does have its use, but it is different from that of `dg-test-timeout-factor', hence the need for a separate setting. Maciej