From: "Maciej W. Rozycki" <macro@embecosm.com>
To: gcc-patches@gcc.gnu.org
Subject: [PATCH 1/2] RISC-V/testsuite: Widen coverage for pr105314.c
Date: Thu, 11 Jan 2024 23:35:37 +0000 (GMT) [thread overview]
Message-ID: <alpine.DEB.2.20.2401112306560.5892@tpp.orcam.me.uk> (raw)
In-Reply-To: <alpine.DEB.2.20.2401112257440.5892@tpp.orcam.me.uk>
The optimization levels pr105314.c is iterated over are needlessly
overridden with "-O2", limiting the coverage of the test case to that
level, perhaps with additional options the original optimization level
has been supplied with. We could prevent the extra iterations other
than "-O2" from being run, but the transformation made by if-conversion
is also expected to happen at other optimization levels, so include them
all, and also make sure no reverse-condition branch appears in output,
moving the `dg-final' command to the bottom, as with most test cases.
gcc/testsuite/
* gcc.target/riscv/pr105314.c: Replace `dg-options' command with
`dg-skip-if'. Also reject "bne" with `dg-final'.
---
Hi,
Technically it's not a single self-contained change and it could be 3
instead, but I think there's little point in splitting it further.
Maciej
---
gcc/testsuite/gcc.target/riscv/pr105314.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
gcc-test-riscv-pr105314-levels.diff
Index: gcc/gcc/testsuite/gcc.target/riscv/pr105314.c
===================================================================
--- gcc.orig/gcc/testsuite/gcc.target/riscv/pr105314.c
+++ gcc/gcc/testsuite/gcc.target/riscv/pr105314.c
@@ -1,7 +1,6 @@
/* PR rtl-optimization/105314 */
/* { dg-do compile } */
-/* { dg-options "-O2" } */
-/* { dg-final { scan-assembler-not "\tbeq\t" } } */
+/* { dg-skip-if "" { *-*-* } { "-O0" "-Og" "-Os" "-Oz" } } */
long
foo (long a, long b, long c)
@@ -10,3 +9,5 @@ foo (long a, long b, long c)
a = 0;
return a;
}
+
+/* { dg-final { scan-assembler-not "\\s(?:beq|bne)\\s" } } */
next prev parent reply other threads:[~2024-01-11 23:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 23:35 [PATCH 0/2] RISC-V/testsuite: A couple of improvements " Maciej W. Rozycki
2024-01-11 23:35 ` Maciej W. Rozycki [this message]
2024-01-12 9:54 ` [PATCH 1/2] RISC-V/testsuite: Widen coverage " Kito Cheng
2024-01-11 23:35 ` [PATCH 2/2] RISC-V/testsuite: Also verify if-conversion runs " Maciej W. Rozycki
2024-01-12 9:53 ` Kito Cheng
2024-01-12 10:04 ` Andrew Pinski
2024-01-12 13:59 ` Maciej W. Rozycki
2024-01-16 14:22 ` Jeff Law
2024-01-16 15:33 ` Maciej W. Rozycki
2024-01-24 11:26 ` Maciej W. Rozycki
2024-01-24 17:24 ` Jeff Law
2024-01-26 21:49 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.2401112306560.5892@tpp.orcam.me.uk \
--to=macro@embecosm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).