From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by sourceware.org (Postfix) with ESMTPS id 7928B3858401 for ; Wed, 24 Jan 2024 11:26:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7928B3858401 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7928B3858401 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::52b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706095588; cv=none; b=FJIMZxXB4MTgPS0jgGinRcQe655Z74nwwMI3J5EFquWEtj45vlXSgHCgihA6bR0wAgOihh1Rcvjfr/IdKNxHokM2DGiNHMEgrr60QdNlyujO+cvMGs0bv0oJoTonEg/PQAEnXFtIkqT0LnRZzqMFbLVwuqYhF0pOivJZrQpIp74= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706095588; c=relaxed/simple; bh=pbrs4QnNnvm2MIG/t9FLhwef17ZIty5BeaSp076mkSk=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=gZ+dJS5SduszGztqI3pPk1CxrzvpV/pcL1jN/CQ9Fz3fUCsEYy/Knu2n/BAJ99f+1NF9FBWc6BtuNAp83T/fF1hgPe1qyX7Tu9/L5e6U4nR7XmWv6fOKv31mOwy+1Fnv4klvOmoTYVqm2e+akCf4yroGwvLTdnO/VL5z2XSWqgk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-559f92bf7b6so9684462a12.0 for ; Wed, 24 Jan 2024 03:26:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; t=1706095585; x=1706700385; darn=gcc.gnu.org; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TFjAIYVhryQKl980aMG6WrAo3/86EXKvmYpSk3mU5lw=; b=gaU7vE9f8iEkT+HfJBdShpzb82FbCYB33aO+jTH1ZzESLktj5IELXAzRy6LzQyv+o4 Wty6mTttMbZVW4Cbxji5hmAGzTq/t0l3SbpnI229v8gjFpmInTa+9j3j85yM4LGkzrmz Hltn48QXQwDTezwtZ8Uu1o4JdcdWJ9bnOzTC4N0KVNwaTt5yBoJH1sf4GUB+EeRlih4z xetNTAme4ix0keAhuPcrAdvHtVlvajVeL3hSUWX0BtDnshyw1idZwgtkp5rFxpGuavmY MMNw4EzLTH/S7AQ9+zo3b+thtLKZlDPq+S5rlrlSXpgK8KVyQYn9k6+3dWKDDtd5vb7L qWiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706095585; x=1706700385; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TFjAIYVhryQKl980aMG6WrAo3/86EXKvmYpSk3mU5lw=; b=LR4kaxrSpok5iuqdP/qX0lfn1QsT0YdsPLI+8wepdEWOyxg7LAybGL1oVBAjmKzelt vG55/gkklDkIkor5TPD2Jt4Ld+mVn3S7ZeeyS/AMj6Z6qUhPjz1OSDaaODbC8WNaRhu5 yPPMso71jRpePj+YQK5eBAWf2XQCxykPQxIZWSAY2L3QaQoUXTw/qf+RVqjLhOrA7aUQ WxZW/XMTZTazlEB8lahExfGJr1TnQAS90O0YD+7eRqp7ln3uy+2ZEnkyFwsJXnLbTUrQ 4pZHEkE7iQDb/UmNar3SSnL1Y7BFOrbLZ7JopRcygX3sf8hZJ0Tw1WbZxVNce/tq2wod 4lvw== X-Gm-Message-State: AOJu0Ywh8Ise8FiLjas+TNfN0WkJ1myrrtp0r5EK61d/qfk9hwDC3R/X EdtYadAQ3saPjLxTv6pOWZfNEyiC2U35Je8jvrdgPBZzNfxYQvAFufVjF2I6gCg= X-Google-Smtp-Source: AGHT+IEbMebVTp78cxX1GLIec17e0hMAFvZ6owt33ctDR1Uetl/hifY2syMH7p80hsTTqRQ247H+qQ== X-Received: by 2002:a05:6402:2292:b0:55c:828e:4bfa with SMTP id cw18-20020a056402229200b0055c828e4bfamr1026900edb.12.1706095585124; Wed, 24 Jan 2024 03:26:25 -0800 (PST) Received: from annie.orcam.me.uk (annie.orcam.me.uk. [78.133.224.48]) by smtp.gmail.com with ESMTPSA id o22-20020aa7dd56000000b0055c60ba9640sm2553502edw.77.2024.01.24.03.26.24 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Jan 2024 03:26:24 -0800 (PST) Date: Wed, 24 Jan 2024 11:26:23 +0000 (GMT) From: "Maciej W. Rozycki" To: Jeff Law , Andrew Pinski cc: gcc-patches@gcc.gnu.org, Andrew Waterman , Jim Wilson , Kito Cheng , Palmer Dabbelt Subject: Re: [PATCH 2/2] RISC-V/testsuite: Also verify if-conversion runs for pr105314.c In-Reply-To: Message-ID: References: <2e8eae88-7853-4b97-bd2c-d32742c2ea16@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 16 Jan 2024, Maciej W. Rozycki wrote: > > I don't have a strong opinion on this. I certainly see Andrew's point, but > > it's also the case that if some work earlier in the RTL or gimple pipeline > > comes along and compromises the test, then we'd see the failure and deal with > > it. It's pretty standard procedure. > > I'll be happy to add an RTL test case, also for my recent complementary > cset-sext.c addition and maybe other if-conversion pieces recently added. > I think that does not preclude arming pr105314.c with RTL scanning though. I have made a buch of testcases as we discussed at the meeting last week and the RTL parser did not blow up, so I have now submitted them. See: and the next two messages (threading broke with this submission for some reason, probably due to a glitch in my mail client I've seen from time to time; I guess it's not worth it to get the patch series resubmitted as they are independent from each other really and can be applied in any order). I haven't heard back from Andrew beyond his initial message, so it's not clear to me whether he maintains his objection in spite the arguments given. Andrew? Do we have consensus now to move forward with this change as posted? I'd like to get these patches ticked off ASAP. Maciej