From: "Maciej W. Rozycki" <macro@embecosm.com>
To: Jeff Law <jeffreyalaw@gmail.com>
Cc: Andrew Pinski <pinskia@gmail.com>,
gcc-patches@gcc.gnu.org, Andrew Waterman <andrew@sifive.com>,
Jim Wilson <jim.wilson.gcc@gmail.com>,
Kito Cheng <kito.cheng@gmail.com>,
Palmer Dabbelt <palmer@dabbelt.com>
Subject: Re: [PATCH 2/2] RISC-V/testsuite: Also verify if-conversion runs for pr105314.c
Date: Fri, 26 Jan 2024 21:49:48 +0000 (GMT) [thread overview]
Message-ID: <alpine.DEB.2.20.2401262148330.14163@tpp.orcam.me.uk> (raw)
In-Reply-To: <9bc6a163-7fd0-4c34-a3f2-2315708fc642@gmail.com>
On Wed, 24 Jan 2024, Jeff Law wrote:
> > Do we have consensus now to move forward with this change as posted? I'd
> > like to get these patches ticked off ASAP.
> I think it should move forward. I think having the RTL tests deals with
> Andrew's concern and the testcase adjustment has value as well.
>
> I ACK's the RTL tests a few minutes ago and we should consider the 1/2 and 2/2
> of the original OK now as well.
I have committed both patch series now, thank you for your assistance and
review.
Maciej
prev parent reply other threads:[~2024-01-26 21:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 23:35 [PATCH 0/2] RISC-V/testsuite: A couple of improvements " Maciej W. Rozycki
2024-01-11 23:35 ` [PATCH 1/2] RISC-V/testsuite: Widen coverage " Maciej W. Rozycki
2024-01-12 9:54 ` Kito Cheng
2024-01-11 23:35 ` [PATCH 2/2] RISC-V/testsuite: Also verify if-conversion runs " Maciej W. Rozycki
2024-01-12 9:53 ` Kito Cheng
2024-01-12 10:04 ` Andrew Pinski
2024-01-12 13:59 ` Maciej W. Rozycki
2024-01-16 14:22 ` Jeff Law
2024-01-16 15:33 ` Maciej W. Rozycki
2024-01-24 11:26 ` Maciej W. Rozycki
2024-01-24 17:24 ` Jeff Law
2024-01-26 21:49 ` Maciej W. Rozycki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.2401262148330.14163@tpp.orcam.me.uk \
--to=macro@embecosm.com \
--cc=andrew@sifive.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=jim.wilson.gcc@gmail.com \
--cc=kito.cheng@gmail.com \
--cc=palmer@dabbelt.com \
--cc=pinskia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).