From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41718 invoked by alias); 11 Jan 2018 06:57:28 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 40204 invoked by uid 89); 11 Jan 2018 06:57:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=H*R:D*gcc.gnu.org, H*R:D*gnu.org X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail3-relais-sop.national.inria.fr Received: from mail3-relais-sop.national.inria.fr (HELO mail3-relais-sop.national.inria.fr) (192.134.164.104) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 Jan 2018 06:57:19 +0000 Received: from ip-122.net-89-2-94.rev.numericable.fr (HELO stedding) ([89.2.94.122]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jan 2018 07:57:16 +0100 Date: Thu, 11 Jan 2018 07:03:00 -0000 From: Marc Glisse Reply-To: libstdc++@gcc.gnu.org To: =?ISO-8859-15?Q?Fran=E7ois_Dumont?= cc: gcc-patches , "libstdc++@gcc.gnu.org" Subject: Re: std::vector default default and move constructors In-Reply-To: <2b6cd500-135a-4d23-9cfd-e064efabdfa7@gmail.com> Message-ID: References: <2b48d135-7b0f-f8ec-73f5-15932c2a8581@gmail.com> <1653b9da-8fee-d534-0185-3a63a69d5ca1@gmail.com> <2b6cd500-135a-4d23-9cfd-e064efabdfa7@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=ISO-8859-15 Content-Transfer-Encoding: 8BIT X-SW-Source: 2018-01/txt/msg00848.txt.bz2 On Thu, 11 Jan 2018, François Dumont wrote: - void _M_swap_data(_Vector_impl& __x) _GLIBCXX_NOEXCEPT + void + _M_swap_data(_Vector_impl_data& __x) _GLIBCXX_NOEXCEPT { std::swap(_M_start, __x._M_start); std::swap(_M_finish, __x._M_finish); std::swap(_M_end_of_storage, __x._M_end_of_storage); } I don't remember earlier discussions about this patch, but is this piece of code still needed? std::swap(*this, __x) looks like it should work. -- Marc Glisse