public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Marc Glisse <marc.glisse@inria.fr>
To: "François Dumont" <frs.dumont@gmail.com>
Cc: "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>,
	    gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: Share ebo helper throughout lib
Date: Wed, 25 Jul 2018 19:53:00 -0000	[thread overview]
Message-ID: <alpine.DEB.2.21.1807252145440.25668@stedding.saclay.inria.fr> (raw)
In-Reply-To: <1b6ec4c9-cdf9-2b7c-f263-185e70029d54@gmail.com>

On Wed, 25 Jul 2018, François Dumont wrote:

>     It has already been noticed that there are 2 ebo helpers in the lib. Here 
> is a patch to use 1.
>
>
>     * include/bits/ebo_helper.h: New.
>     * include/Makefile.am: Add latter.
>     * include/Makefile.in: Regenerate.
>     * include/bits/hashtable_policy.h: Adapt.
>     * include/bits/shared_ptr_base.h: Adapt.
>
> Tested under linux x86_64.
>
> Ok to commit ?

I don't think we support [[no_unique_address]] yet, but assuming we soon 
will and we enable it also for C++03 (at least with the __attribute__ 
syntax and/or in system headers), do you know if some similar helper will 
still be necessary, with a simpler implementation, or if the attribute 
will magically get rid of it?

(I haven't looked at it at all, the answer may be obvious)

-- 
Marc Glisse

  reply	other threads:[~2018-07-25 19:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-25 19:42 François Dumont
2018-07-25 19:53 ` Marc Glisse [this message]
2018-07-25 20:04   ` Jonathan Wakely
2018-07-25 19:58 ` Jonathan Wakely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1807252145440.25668@stedding.saclay.inria.fr \
    --to=marc.glisse@inria.fr \
    --cc=frs.dumont@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).