From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34569 invoked by alias); 5 Sep 2018 14:22:36 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 33563 invoked by uid 89); 5 Sep 2018 14:22:35 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=contrib X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Sep 2018 14:22:34 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=svr-ies-mbx-01.mgc.mentorg.com) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1fxYhU-0002HZ-Gs from joseph_myers@mentor.com for gcc-patches@gcc.gnu.org; Wed, 05 Sep 2018 07:22:32 -0700 Received: from digraph.polyomino.org.uk (137.202.0.90) by svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Wed, 5 Sep 2018 15:22:28 +0100 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.90_1) (envelope-from ) id 1fxYhQ-0005pg-GH; Wed, 05 Sep 2018 14:22:28 +0000 Date: Wed, 05 Sep 2018 14:22:00 -0000 From: Joseph Myers To: Andrew Stubbs CC: Subject: Re: [PATCH 21/25] GCN Back-end (part 2/2). In-Reply-To: <4c633833-1954-4b62-1a96-4f1c2cf541fd@codesourcery.com> Message-ID: References: <4c633833-1954-4b62-1a96-4f1c2cf541fd@codesourcery.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2018-09/txt/msg00314.txt.bz2 On Wed, 5 Sep 2018, Andrew Stubbs wrote: > + warning_at (decl ? DECL_SOURCE_LOCATION (decl) : UNKNOWN_LOCATION, > + OPT_Wopenacc_dims, > + (dims[GOMP_DIM_VECTOR] > + ? "using vector_length (64), ignoring %d" > + : "using vector_length (64), ignoring runtime setting"), In cases like this with alternative diagnostic messages using ?:, you need to mark up each message with G_() so they both get extracted for translation by exgettext. > + fatal_error (input_location, "COLLECT_GCC must be set."); No '.' at end of diagnostic. > +#define STR "-foffload-abi=" > + fatal_error (input_location, > + "unrecognizable argument of option " STR); This concatenation with a macro won't work with exgettext extracting messages for translation. > + fatal_error (input_location, "cannot open '%s'", gcn_s2_name); > + fatal_error (input_location, "cannot open '%s'", gcn_cfile_name); Use %qs (presuming this code is using the generic diagnostic machinery that supports it). +gcn-run$(exeext): gcn-run.o + +$(LINKER) $(ALL_LINKERFLAGS) $(LDFLAGS) -o $@ $< -ldl I'd expect this to fail on non-Unix configurations that don't have -ldl, and thus to need appropriate conditionals / configure tests to avoid that build failure. A new port should add an appropriate entry to contrib/config-list.mk. You should also verify that the port does build using that contrib/config-list.mk entry, with the same version of GCC, built natively, in the PATH, or equivalently that the port builds with the same version of GCC, built natively, in the PATH, when you configure with --enable-werror-always and the other options config-list.mk uses - this is the cross-compiler equivalent of the native use of -Werror in the later stages of bootstrap. (Preferably verify this building for both 32-bit and 64-bit hosts, since it's easy to have warnings that only show up for one but not the other.) -- Joseph S. Myers joseph@codesourcery.com