From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64694 invoked by alias); 26 Sep 2018 19:50:57 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 64412 invoked by uid 89); 26 Sep 2018 19:50:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Sep 2018 19:50:55 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=svr-ies-mbx-01.mgc.mentorg.com) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1g5Fpl-0004tp-CA from joseph_myers@mentor.com for gcc-patches@gcc.gnu.org; Wed, 26 Sep 2018 12:50:53 -0700 Received: from digraph.polyomino.org.uk (137.202.0.90) by svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Wed, 26 Sep 2018 20:50:49 +0100 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.90_1) (envelope-from ) id 1g5Fph-0004vM-9Y; Wed, 26 Sep 2018 19:50:49 +0000 Date: Wed, 26 Sep 2018 20:28:00 -0000 From: Joseph Myers To: Cesar Philippidis CC: "gcc-patches@gcc.gnu.org" , Thomas Schwinge Subject: Re: [patch,openacc] C, C++ OpenACC wait diagnostic change In-Reply-To: <38bae4a6-8ef1-b1df-95e2-54f03e07f173@codesourcery.com> Message-ID: References: <38bae4a6-8ef1-b1df-95e2-54f03e07f173@codesourcery.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2018-09/txt/msg01608.txt.bz2 On Wed, 26 Sep 2018, Cesar Philippidis wrote: > Attached is an old patch which updated the C and C++ FEs to use %<)%> > for the right ')' symbol. It's mostly a cosmetic change. All of the > changes are self-contained to the OpenACC code path. Why is the "before ')'" included in the call to c_parser_error at all? c_parser_error calls c_parse_error which adds its own " before " and token description or expansion, so I'd expect the current error to result in a message ending in something of the form "before X before Y". -- Joseph S. Myers joseph@codesourcery.com