From: Joseph Myers <joseph@codesourcery.com>
To: Martin Sebor <msebor@gmail.com>
Cc: Jason Merrill <jason@redhat.com>,
Gcc Patch List <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] detect attribute mismatches in alias declarations (PR 81824)
Date: Wed, 24 Oct 2018 12:50:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.21.1810241220030.21465@digraph.polyomino.org.uk> (raw)
In-Reply-To: <21833fc0-d4ca-d239-7194-49fe90a2f6d4@gmail.com>
On Wed, 24 Oct 2018, Martin Sebor wrote:
> But if you do want to avoid the attribute on declarations of
> these functions regardless it should be safe to add it after
> the declaration in the .c file, like so:
>
> __hidden_ver1 (strcmp, __GI_strcmp, __redirect_strcmp)
> __attribute__ ((visibility ("hidden"), copy (strcmp)));
The obvious question there is whether the glibc patch should use copy
(local) as well as copy (name) in the definition of __hidden_ver1.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2018-10-24 12:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-01 21:01 Martin Sebor
2018-10-01 23:47 ` Joseph Myers
2018-10-23 7:29 ` Martin Sebor
2018-10-23 22:55 ` Joseph Myers
2018-10-24 9:06 ` Martin Sebor
2018-10-24 12:50 ` Joseph Myers [this message]
2018-10-24 17:00 ` Martin Sebor
2018-10-24 19:00 ` Joseph Myers
2018-10-24 21:29 ` Martin Sebor
2018-10-31 16:35 ` Martin Sebor
2018-10-24 13:04 ` Joseph Myers
2018-10-24 18:33 ` Martin Sebor
2018-11-07 21:59 ` Jeff Law
2018-11-09 17:33 ` Martin Sebor
2018-11-12 18:29 ` Matthew Malcomson
2018-11-12 18:38 ` Martin Sebor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1810241220030.21465@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=msebor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).