From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129408 invoked by alias); 26 Nov 2018 18:45:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 129156 invoked by uid 89); 26 Nov 2018 18:45:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Nov 2018 18:45:23 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-MBX-03.mgc.mentorg.com) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1gRLsV-0005gv-Bw from joseph_myers@mentor.com ; Mon, 26 Nov 2018 10:45:03 -0800 Received: from digraph.polyomino.org.uk (137.202.0.90) by SVR-IES-MBX-03.mgc.mentorg.com (139.181.222.3) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Mon, 26 Nov 2018 18:44:59 +0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.90_1) (envelope-from ) id 1gRLsR-0000cS-Gi; Mon, 26 Nov 2018 18:44:59 +0000 Date: Mon, 26 Nov 2018 18:45:00 -0000 From: Joseph Myers To: =?ISO-8859-15?Q?Martin_Li=A8ka?= CC: Jakub Jelinek , Bernhard Reutner-Fischer , Richard Biener , "fortran@gcc.gnu.org" , Thomas Koenig , Toon Moene , GCC Patches Subject: Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include. In-Reply-To: Message-ID: References: <0e9bfe91-eed3-f6e0-9cb6-97c615325fa6@suse.cz> <20181114113527.GP11625@tucnak> <20181115205423.GC11625@tucnak> <041fb30d-f232-d526-0d8a-275d5ceafa2d@suse.cz> <20181116134952.GI11625@tucnak> <9979fb3e-f010-a48a-8ab7-55017d2d4c81@suse.cz> <20181120142731.GA11625@tucnak> <3e302273-8b8d-ab4b-e0e5-cb3a3c5ef8e3@suse.cz> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="-1152306461-2108422036-1543257899=:30345" X-SW-Source: 2018-11/txt/msg02106.txt.bz2 ---1152306461-2108422036-1543257899=:30345 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Content-length: 1131 On Mon, 26 Nov 2018, Martin Liška wrote: > > I don't see how this version ensures that NATIVE_SYSTEM_HEADER_DIR is > > properly sysrooted. Note there's add_sysrooted_prefix separate from > > add_prefix (but that's *not* the correct thing to use here because it uses > > target_sysroot_suffix whereas you need target_sysroot_hdrs_suffix). > > I address that in updated version of the patch. However, this version seems to make TOOL_INCLUDE_DIR sysrooted as well. I don't think that's correct; TOOL_INCLUDE_DIR ($prefix/$target/include, roughly) is a non-sysroot location for headers. Note that it's not sysrooted in cppdefault.c, which is a good guide to which directories should or should not be sysrooted, and what order they should come in (though as discussed, various of the directories there are not relevant for the present issue). The patch appears to be against some tree other than current trunk. At least, it shows a function find_fortran_preinclude_file in gcc.c as already existing in the diff context, but I see no such function in the current sources. -- Joseph S. Myers joseph@codesourcery.com ---1152306461-2108422036-1543257899=:30345--