From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66529 invoked by alias); 29 Nov 2018 21:28:38 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 66508 invoked by uid 89); 29 Nov 2018 21:28:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 29 Nov 2018 21:28:36 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=svr-ies-mbx-01.mgc.mentorg.com) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1gSTrN-0000gd-LV from joseph_myers@mentor.com for gcc-patches@gcc.gnu.org; Thu, 29 Nov 2018 13:28:33 -0800 Received: from digraph.polyomino.org.uk (137.202.0.90) by svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Thu, 29 Nov 2018 21:28:30 +0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.90_1) (envelope-from ) id 1gSTrJ-0007t4-QV; Thu, 29 Nov 2018 21:28:29 +0000 Date: Thu, 29 Nov 2018 21:28:00 -0000 From: Joseph Myers To: Julian Brown CC: Cesar Philippidis , "gcc-patches@gcc.gnu.org" , Thomas Schwinge Subject: Re: [patch,openacc] C, C++ OpenACC wait diagnostic change In-Reply-To: <20181129212223.3fb2dfa6@squid.athome> Message-ID: References: <38bae4a6-8ef1-b1df-95e2-54f03e07f173@codesourcery.com> <47265b45-bc7d-6bb5-eba3-fe0697202803@codesourcery.com> <20180928141742.7352e5e7@squid.athome> <20181129212223.3fb2dfa6@squid.athome> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2018-11/txt/msg02500.txt.bz2 On Thu, 29 Nov 2018, Julian Brown wrote: > > But for C, it does not appear that c_parser_expr_list has a code path > > that can return a zero-length list at all. So, we can elide the > > diagnostic with no change to compiler behaviour. This patch does that, > > and also changes the C++ diagnostic, leading to errors being reported > > like: The c-parser.c change is OK. -- Joseph S. Myers joseph@codesourcery.com