From: Joseph Myers <joseph@codesourcery.com>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Use proper print formatter in main function in fixincl.c
Date: Thu, 20 Dec 2018 00:20:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.21.1812200018160.10617@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20181219233514.13889-1-xerofoify@gmail.com>
This patch is wrong for multiple reasons (the %d you're changing is for an
int argument, so is correct as-is, and %lu is not portable for size_t, so
since we may not be able to assume C99 %zu on the host you'd need to cast
the ttl_data_size argument explicitly to unsigned long int to use %lu for
it).
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2018-12-20 0:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-19 23:35 Nicholas Krause
2018-12-20 0:20 ` Joseph Myers [this message]
2018-12-20 2:49 Nicholas Krause
2018-12-20 21:07 ` Joseph Myers
2018-12-20 22:19 ` nick
2018-12-20 22:27 Nicholas Krause
2019-01-07 15:57 ` Jonathan Wakely
2019-01-07 16:02 ` NightStrike
2019-01-07 16:04 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1812200018160.10617@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).