From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32366 invoked by alias); 9 Jan 2019 17:21:54 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 32347 invoked by uid 89); 9 Jan 2019 17:21:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Jan 2019 17:21:52 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=svr-ies-mbx-01.mgc.mentorg.com) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1ghHY6-0004C9-72 from joseph_myers@mentor.com ; Wed, 09 Jan 2019 09:21:50 -0800 Received: from digraph.polyomino.org.uk (137.202.0.90) by svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Wed, 9 Jan 2019 17:21:47 +0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.90_1) (envelope-from ) id 1ghHY2-0006eL-Cs; Wed, 09 Jan 2019 17:21:46 +0000 Date: Wed, 09 Jan 2019 17:21:00 -0000 From: Joseph Myers To: =?ISO-8859-15?Q?Martin_Li=A8ka?= CC: Jakub Jelinek , Bernhard Reutner-Fischer , Richard Biener , "fortran@gcc.gnu.org" , Thomas Koenig , Toon Moene , GCC Patches Subject: Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include. In-Reply-To: Message-ID: References: <20181115205423.GC11625@tucnak> <041fb30d-f232-d526-0d8a-275d5ceafa2d@suse.cz> <20181116134952.GI11625@tucnak> <9979fb3e-f010-a48a-8ab7-55017d2d4c81@suse.cz> <20181120142731.GA11625@tucnak> <3e302273-8b8d-ab4b-e0e5-cb3a3c5ef8e3@suse.cz> <33d4a41b-8da7-c970-8150-18f42675bd39@suse.cz> <3bc64078-e4cf-14f1-cdac-5dd844826db0@suse.cz> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2019-01/txt/msg00495.txt.bz2 On Wed, 9 Jan 2019, Joseph Myers wrote: > Also, could you clarify what, in the patch > (if that's > still the current version), > > > + add_sysrooted_hdrs_prefix (&prefixes, argv[2], NULL, 0, 0, false); > > is doing (that is, examples of what sort of prefixes it's adding)? (I guess this indicates something for the next revision of the patch - if each add_sysrooted_hdrs_prefix call has a comment indicating the sort of path you expect to be searched, e.g. /usr/include/finclude/, that would help both review and subsequent readers of the code.) -- Joseph S. Myers joseph@codesourcery.com