From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67774 invoked by alias); 15 Jan 2019 17:59:34 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 67751 invoked by uid 89); 15 Jan 2019 17:59:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:770 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 15 Jan 2019 17:59:31 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-MBX-03.mgc.mentorg.com) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1gjSzp-0002YS-QP from joseph_myers@mentor.com ; Tue, 15 Jan 2019 09:59:29 -0800 Received: from digraph.polyomino.org.uk (137.202.0.90) by SVR-IES-MBX-03.mgc.mentorg.com (139.181.222.3) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Tue, 15 Jan 2019 17:59:26 +0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.90_1) (envelope-from ) id 1gjSzl-00047P-Tx; Tue, 15 Jan 2019 17:59:25 +0000 Date: Tue, 15 Jan 2019 17:59:00 -0000 From: Joseph Myers To: Jason Merrill CC: Tom Honermann , Martin Sebor , gcc-patches , Marek Polacek Subject: Re: PATCH: Updated error messages for ill-formed cases of array initialization by string literal In-Reply-To: <99ca7332-f658-d5fe-fc42-b4199111ad3d@redhat.com> Message-ID: References: <50dbd993-f778-a2a4-e63c-1c2b3b85de41@gmail.com> <21994e14-d1b8-e893-72d2-86b9674e0fab@honermann.net> <99ca7332-f658-d5fe-fc42-b4199111ad3d@redhat.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2019-01/txt/msg00861.txt.bz2 On Tue, 15 Jan 2019, Jason Merrill wrote: > I actually incorporated the C++ part of these changes into yesterday's commit, > using Martin's first suggestion. Here's the adjusted C patch, which I'd like > a C maintainer to approve. The front-end changes are OK. However, in the testcase changes, some of the new expected diagnostics are hardcoding that "unsigned int" is the type of char32_t, which isn't correct for all platforms (for example, it's definitely not the type when int is 16-bit). In principle the same applies to diagnostics hardcoding the choice of char16_t, although variations are at least less likely there. -- Joseph S. Myers joseph@codesourcery.com