From: Joseph Myers <joseph@codesourcery.com>
To: Jason Merrill <jason@redhat.com>
Cc: Lewis Hyatt <lhyatt@gmail.com>, <gcc-patches@gcc.gnu.org>
Subject: Re: Patch to support extended characters in C/C++ identifiers
Date: Thu, 15 Aug 2019 12:51:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.21.1908151222350.4667@digraph.polyomino.org.uk> (raw)
In-Reply-To: <83914efb-c81b-eb26-9799-cc7df1053af2@redhat.com>
On Thu, 15 Aug 2019, Jason Merrill wrote:
> On 8/12/19 6:01 PM, Lewis Hyatt wrote:
> > Hello-
> >
> > The attached patch for libcpp adds support for extended characters (e.g.
> > UTF-8)
> > in identifiers. A preliminary version of the patch was posted on PR c/67224
> > as
> > Comment 26 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67224#c26) and
> > discussed with Joseph Myers. Here is an updated patch incorporating all
> > feedback received so far. I hope it is suitable now; please let me know if I
> > can do anything else to make it ready for you to apply. I am happy to work
> > on
> > it further, whatever is needed. I can't easily test on anything other than
> > x86_64-linux though. I did bootstrap all languages and run all tests on that
> > platform, everything was good.
> >
> > The (relatively short) changes to libcpp are included inline here. I
> > attached
> > the test cases as a gzipped patch to avoid any problems with the encoding
> > (the
> > test cases contain some invalid UTF-8 and also other encodings such as
> > latin-1
> > as part of the testing).
> >
> > Thanks for taking a look at it!
>
> Looks good to me. Joseph?
I'm a month behind on gcc-patches at present. It will take me a while to
get to this for detailed review.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2019-08-15 12:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 22:16 Lewis Hyatt
2019-08-15 7:41 ` Jason Merrill
2019-08-15 12:51 ` Joseph Myers [this message]
2019-09-10 23:47 ` Joseph Myers
2019-09-11 14:32 ` Lewis Hyatt
2019-09-12 0:33 ` Joseph Myers
2019-09-12 20:30 ` Lewis Hyatt
2019-09-19 19:57 ` Joseph Myers
2019-09-19 20:08 ` Lewis Hyatt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1908151222350.4667@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=lhyatt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).