From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76698 invoked by alias); 15 Aug 2019 12:23:16 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 76689 invoked by uid 89); 15 Aug 2019 12:23:15 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,KAM_SHORT,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: esa4.mentor.iphmx.com Received: from esa4.mentor.iphmx.com (HELO esa4.mentor.iphmx.com) (68.232.137.252) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 15 Aug 2019 12:23:14 +0000 IronPort-SDR: 7HzQZ8a1HId8mfCRiOCWj00gDo7xACYmIq5lkqTTS5pNcb4DWPcv/QbcbNBvC6FZs8HsC9/rO4 ziNjoUoMQfmlTeZiDXgSiayILDuQrrk5mTMc76tIlw6ueqq7VJ2O+GbZyrOcSIx2TMf1ykwgJE b0Dhz+6vr9anuS8T5yFLBRVqByJlqbI6R+bGgvp3D/2hpAGh9tP1v559bfAtA+sHlxCBM4Oh/g 2eMD4DP+g1a92WJKZNV1bcBzbt5nxu13KXcBCpqluH5+H56+Pk7opduP51gT3S1XXIXu300BE+ sbY= Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa4.mentor.iphmx.com with ESMTP; 15 Aug 2019 04:23:12 -0800 IronPort-SDR: g65GfoeIJ8g8oaDBz9WpUE0dR0Ek7mYKJbgZRLXKlucGSaoSDF7qFp7Ci1AKCs/HA5iSIBQbdG 7OivmFF2IItahp+kzbT4qIe3enaqRoS/NpBEIX5F1dQHB8lGnj07j/mg25HlIGsBkiylGSazdz bezi8NQc3uhJxzOqaeYgzBPIf5/8X6gWzuyKBiDpUmdIzcjUqIW5RgbDXy4zP6TE8TW5iQAAgf xcucnct1j7vsv2hOEhJdr552uorVgRuR+4RffHtAKIgKmoFoOgX1G5ki3PctlGGKxLoI9Su9eu UOA= Date: Thu, 15 Aug 2019 12:51:00 -0000 From: Joseph Myers To: Jason Merrill CC: Lewis Hyatt , Subject: Re: Patch to support extended characters in C/C++ identifiers In-Reply-To: <83914efb-c81b-eb26-9799-cc7df1053af2@redhat.com> Message-ID: References: <20190812220121.GA9251@ldh.local> <83914efb-c81b-eb26-9799-cc7df1053af2@redhat.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Return-Path: joseph@codesourcery.com X-SW-Source: 2019-08/txt/msg01094.txt.bz2 On Thu, 15 Aug 2019, Jason Merrill wrote: > On 8/12/19 6:01 PM, Lewis Hyatt wrote: > > Hello- > > > > The attached patch for libcpp adds support for extended characters (e.g. > > UTF-8) > > in identifiers. A preliminary version of the patch was posted on PR c/67224 > > as > > Comment 26 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67224#c26) and > > discussed with Joseph Myers. Here is an updated patch incorporating all > > feedback received so far. I hope it is suitable now; please let me know if I > > can do anything else to make it ready for you to apply. I am happy to work > > on > > it further, whatever is needed. I can't easily test on anything other than > > x86_64-linux though. I did bootstrap all languages and run all tests on that > > platform, everything was good. > > > > The (relatively short) changes to libcpp are included inline here. I > > attached > > the test cases as a gzipped patch to avoid any problems with the encoding > > (the > > test cases contain some invalid UTF-8 and also other encodings such as > > latin-1 > > as part of the testing). > > > > Thanks for taking a look at it! > > Looks good to me. Joseph? I'm a month behind on gcc-patches at present. It will take me a while to get to this for detailed review. -- Joseph S. Myers joseph@codesourcery.com