From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-511930-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 8425 invoked by alias); 28 Oct 2019 23:25:09 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 8414 invoked by uid 89); 28 Oct 2019 23:25:08 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-15.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy=lacking
X-HELO: esa2.mentor.iphmx.com
Received: from esa2.mentor.iphmx.com (HELO esa2.mentor.iphmx.com) (68.232.141.98) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 28 Oct 2019 23:25:07 +0000
IronPort-SDR: bR3kJNXZB1qW+4Gn0POZkIlIBX4PC7Rsh4rU2upL8aP4cpgTybenUPb9NndH5pnDfuTEmORyAg AXzKQnoal8mTJ0hL2yMh1NEaFN2XV9sRZlBpyGMB/XqU+HfWXw6eg8YhpFOn2ApFIA8w4m6qTZ 6TLub18+zS+axkVViLXz7vxoTjmsmy7lSh2YXlyNs/BlrhQqrDOwmmPv+Put6dv5yRh+C4wh3N 8/igOqny/6vlnZP32lRwXmzg9KknK36MN0RTXX1QqNz4FR1f+zfiSCros9dztt/VJapDSgQDLn snw=
Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167])  by esa2.mentor.iphmx.com with ESMTP; 28 Oct 2019 15:25:06 -0800
IronPort-SDR: YAeh7MSqk16uDhqBX1jp4r3teFe+EubkOcoSvcvQ4OlyiMtK7xDj87GVOF05Ufln8mkxRBG8X4 WAmE3T+aWclDc001lnrmIV6SEUXo9jyrvG5CAm/ZylEB+IEf4zdl3cXjL6fTEpGTFzz1ryM9FQ Lh5saCApsXOYVpg/lpdZ5dyXCkFK3x42xeVXaiWkYKbueChazsTKgP3i5Ptq4K+faVd6Gn98O+ Pmp7mQT6XLmsBsTofBTSXUMVRtX30T+SI9ZRCBaHVMhPruaxH5cyj/8P4jJXdRWi2tMG8wNs7F Q04=
Date: Mon, 28 Oct 2019 23:56:00 -0000
From: Joseph Myers <joseph@codesourcery.com>
To: Alexandre Oliva <oliva@adacore.com>
CC: <gcc-patches@gcc.gnu.org>, <ebotcazou@adacore.com>, <rguenther@suse.de>
Subject: Re: introduce -fcallgraph-info option
In-Reply-To: <or1rv0run4.fsf@lxoliva.fsfla.org>
Message-ID: <alpine.DEB.2.21.1910282322290.6534@digraph.polyomino.org.uk>
References: <or1rv0run4.fsf@lxoliva.fsfla.org>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Return-Path: joseph@codesourcery.com
X-SW-Source: 2019-10/txt/msg02001.txt.bz2

On Sat, 26 Oct 2019, Alexandre Oliva wrote:

> Regstrapped on x86_64-linux-gnu.  Ok to install?

I have only a peripheral comment:

> diff --git a/gcc/common.opt b/gcc/common.opt
> index cc279f411d796..63d646fba2b42 100644
> --- a/gcc/common.opt
> +++ b/gcc/common.opt
> @@ -1091,6 +1091,14 @@ fbtr-bb-exclusive
>  Common Ignore
>  Does nothing.  Preserved for backward compatibility.
>  
> +fcallgraph-info
> +Common Report RejectNegative Var(flag_callgraph_info) Init(NO_CALLGRAPH_INFO);
> +Output callgraph information on a per-file basis
> +
> +fcallgraph-info=
> +Common Report RejectNegative Joined
> +Output callgraph information on a per-file basis with decorations

We have a test in the testsuite that all option help text consistently 
ends with '.' (see gcc.misc-tests/help.exp).  I'd have expected these 
options, lacking that '.', to cause that test to fail.

-- 
Joseph S. Myers
joseph@codesourcery.com