From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24569 invoked by alias); 28 Nov 2019 18:25:15 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 24555 invoked by uid 89); 28 Nov 2019 18:25:15 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: esa3.mentor.iphmx.com Received: from esa3.mentor.iphmx.com (HELO esa3.mentor.iphmx.com) (68.232.137.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 28 Nov 2019 18:25:14 +0000 IronPort-SDR: 9BPNGVB1m52ojXrJZvw+367UG/QKocuvMKkJnrqS4GzApMTGgdrVZ6+6jNxD4JBv9QXjLIgEE5 maiT4EHInWfbZ0QxyJVDFTbpazVarIaLcKOw0+Z6vMsfQlk8aE3Lwivx/fWbOppan7EpChW8Ng 1/tpTADb2Ea6FIjkhU4VetzEozfTy8wDbalj+Zw+21rR5qZkWBEg/u+WDOpJPgcuxQjKAOGJGU OseGJo9cB/+PcuJZE19yvpOcHx8Ng3vKmqRj8Mfj41wVNuvvDJhxuz9I12MCGr3jqFin3+5QPF gJg= Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa3.mentor.iphmx.com with ESMTP; 28 Nov 2019 10:25:13 -0800 IronPort-SDR: GtX99YCNuZ+Yr9MP2X8WNmI0EOMXIWPAQyjvQp3RBZqg0uYN//WhZ1d/kLtQVvXZQWWwAeUAXw 7aC03fP8vO+KWiQlkyUMktZfZ9KUErBiGeCAageJ6dtuaSpCBEKSQxzGLbAhaLShCiBZ66ycmT KJcilFlLrG4byVchSvYvgcFeJhuNxxKrf+mPdy4GWC8MnsRoU9MqRetKuZucL6zmrI2sxuEr7O 0sJljVpRcYqwWXzxbkiBmbr4EfAgmsSpdVaO4QAfrMTjxj9ValRo7xEEjIFLSbzrMezk+f70Dd MAo= Date: Thu, 28 Nov 2019 19:22:00 -0000 From: Joseph Myers To: Julian Brown CC: , Thomas Schwinge , Segher Boessenkool Subject: Re: [PATCH] Fix decimal floating-point LTO streaming for offloading compilation In-Reply-To: <20191128182129.32a19230@squid.athome> Message-ID: References: <20191128142402.2949931d@squid.athome> <20191128182129.32a19230@squid.athome> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Return-Path: joseph@codesourcery.com X-SW-Source: 2019-11/txt/msg02584.txt.bz2 On Thu, 28 Nov 2019, Julian Brown wrote: > On Thu, 28 Nov 2019 15:04:05 +0000 > Joseph Myers wrote: > > > On Thu, 28 Nov 2019, Julian Brown wrote: > > > > > Unlike e.g. the _FloatN types, when decimal floating-point types are > > > enabled, common tree nodes are created for each float type size > > > (e.g. dfloat32_type_node) and also a pointer to each type is created > > > (e.g. dfloat32_ptr_type_node). tree-streamer.c:record_common_node > > > emits these like: > > > > As far as I can tell, nothing actually uses those pointer nodes, or > > the corresponding BT_DFLOAT32_PTR etc. defined in builtin-types.def. > > I don't know if they ever were used, or if they were just added by > > analogy to e.g. float_ptr_type_node. > > > > So I'd suggest simply removing all references to those tree nodes and > > corresponding BT_*, from builtin-types.def, jit/jit-builtins.c > > (commented out), tree-core.h, tree.c, tree.h. Hopefully that will > > solve the offloading problem. > > Thanks for review. How about this (lightly retested so far), assuming > it passes full testing/bootstrap? This patch is OK. -- Joseph S. Myers joseph@codesourcery.com