From: Joseph Myers <joseph@codesourcery.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Tejas Joshi <tejasjoshi9673@gmail.com>, <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] real: Fix roundeven on inf/nan [PR93663]
Date: Wed, 12 Feb 2020 20:56:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.21.2002122056030.29921@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20200212061901.GV17695@tucnak>
On Wed, 12 Feb 2020, Jakub Jelinek wrote:
> As can be seen in the testcase, roundeven with inf or nan arguments
> ICE because of those asserts where nothing prevents from is_halfway_below
> being called with those arguments.
>
> The following patch fixes that by just returning false for rvc_inf/rvc_nan
> like it returns for rvc_zero, so that we handle roundeven with all those
> values as round. Inf/NaN are not halfway in between two integers...
>
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
OK.
--
Joseph S. Myers
joseph@codesourcery.com
prev parent reply other threads:[~2020-02-12 20:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 3:40 [PATCH] Builtin function roundeven folding implementation Tejas Joshi
2019-07-29 16:49 ` Martin Jambor
2019-08-09 21:26 ` Joseph Myers
2019-08-14 7:24 ` Tejas Joshi
2019-08-21 11:52 ` Martin Jambor
2019-08-21 12:48 ` Joseph Myers
2019-08-21 19:10 ` Martin Jambor
2019-08-21 20:50 ` Joseph Myers
2019-08-22 14:40 ` Martin Jambor
2019-08-22 15:52 ` Joseph Myers
2019-08-22 21:39 ` Tejas Joshi
2019-08-23 12:21 ` Martin Jambor
2019-08-23 21:24 ` Joseph Myers
2019-08-25 20:28 ` Tejas Joshi
2020-02-12 6:20 ` [PATCH] real: Fix roundeven on inf/nan [PR93663] Jakub Jelinek
2020-02-12 20:56 ` Joseph Myers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2002122056030.29921@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=tejasjoshi9673@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).