From: Joseph Myers <joseph@codesourcery.com>
To: Mark Wielaard <mark@klomp.org>
Cc: <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 1/2] Provide diagnostic hints for missing C inttypes.h string constants.
Date: Wed, 3 Jun 2020 23:17:43 +0000 [thread overview]
Message-ID: <alpine.DEB.2.21.2006032317360.7179@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20200601120152.GA2832@wildebeest.org>
On Mon, 1 Jun 2020, Mark Wielaard wrote:
> On Sun, May 24, 2020 at 02:30:13AM +0200, Mark Wielaard wrote:
> > This adds a flag to c_parser so we know when we were trying to
> > construct a string literal. If there is a parse error and we were
> > constructing a string literal, and the next token is an unknown
> > identifier name, and we know there is a standard header that defines
> > that name as a string literal, then add a missing header hint to
> > the error messsage.
> >
> > The list of macro names are also used when providing a hint for
> > missing identifiers.
>
> Ping. Note the followup patch that introduces the same functionality
> for the C++ parser was already approved. This patch (as attached) only
> needs review/approval from a C-frontend maintainer for some of the
> gcc/c/c-parser.c bits.
This patch is OK.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2020-06-03 23:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 23:30 RFC: Provide diagnostic hints for missing " Mark Wielaard
2020-05-22 13:42 ` David Malcolm
2020-05-23 3:01 ` [PATCH] " Mark Wielaard
2020-05-24 0:30 ` Mark Wielaard
2020-05-24 0:30 ` [PATCH 1/2] Provide diagnostic hints for missing C " Mark Wielaard
2020-06-01 12:01 ` Mark Wielaard
2020-06-03 23:17 ` Joseph Myers [this message]
2020-05-24 0:30 ` [PATCH 2/2] Provide diagnostic hints for missing C++ cinttypes " Mark Wielaard
2020-05-25 16:26 ` Jason Merrill
2020-05-28 23:33 ` Mark Wielaard
2020-05-29 12:36 ` David Malcolm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2006032317360.7179@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).