From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Xi Ruoyao <xry111@mengyan1223.wang>
Cc: Richard Sandiford <richard.sandiford@arm.com>,
Jeff Law <jeffreyalaw@gmail.com>,
gcc-patches@gcc.gnu.org, Matthew Fortune <mfortune@gmail.com>
Subject: Re: [PATCH] testsuite: mips: use noinline attribute instead of -fno-inline
Date: Fri, 23 Jul 2021 04:21:53 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.2107230418150.57261@angie.orcam.me.uk> (raw)
In-Reply-To: <mpto8bbn3e4.fsf@arm.com>
On Fri, 9 Jul 2021, Richard Sandiford via Gcc-patches wrote:
> >> > > The "smallest fix" is simply adding -fno-inline into mips.exp.
> >> > > However
> >> > > I don't like it because I agree with you that mips.exp shouldn't
> >> > > care
> >> > > about dg-options, at least don't do it too much.
> >> > As I said in the other message, I think the smallest fix is the way
> >> > to
> >> > go though.
> >> THanks for chiming in Richard. I didn't know all the background
> >> here.
> >> Let's just go with the small fix based on your recommendation. We can
> >> always revisit if we keep running into issues in this code.
> >
> > Pushed at 3b33b113.
>
> It looks like that was the originally posted patch though. It probably
> wasn't very clear, but by smallest fix, I meant adding inline to:
Xi, will you revert your commit that was not approved and apply the
correct fix?
Maciej
next prev parent reply other threads:[~2021-07-23 2:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 7:05 Xi Ruoyao
2021-06-24 16:48 ` Jeff Law
2021-06-24 17:02 ` Xi Ruoyao
2021-06-25 11:13 ` Richard Sandiford
2021-06-25 13:21 ` Xi Ruoyao
2021-06-25 14:40 ` Richard Sandiford
2021-07-08 23:44 ` Jeff Law
2021-07-09 6:42 ` Xi Ruoyao
2021-07-09 11:16 ` Richard Sandiford
2021-07-23 2:21 ` Maciej W. Rozycki [this message]
2021-07-23 3:18 ` Xi Ruoyao
2021-07-23 6:01 ` Xi Ruoyao
2021-07-26 13:55 ` Richard Sandiford
2021-07-26 15:02 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2107230418150.57261@angie.orcam.me.uk \
--to=macro@orcam.me.uk \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=mfortune@gmail.com \
--cc=richard.sandiford@arm.com \
--cc=xry111@mengyan1223.wang \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).