From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <macro@orcam.me.uk>
Received: from angie.orcam.me.uk (angie.orcam.me.uk [IPv6:2001:4190:8020::34])
 by sourceware.org (Postfix) with ESMTP id 229243861C75
 for <gcc-patches@gcc.gnu.org>; Fri, 23 Jul 2021 02:21:55 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 229243861C75
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=orcam.me.uk
Authentication-Results: sourceware.org; spf=none smtp.mailfrom=orcam.me.uk
Received: by angie.orcam.me.uk (Postfix, from userid 500)
 id 00EE292009C; Fri, 23 Jul 2021 04:21:53 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
 by angie.orcam.me.uk (Postfix) with ESMTP id E7CAC92009B;
 Fri, 23 Jul 2021 04:21:53 +0200 (CEST)
Date: Fri, 23 Jul 2021 04:21:53 +0200 (CEST)
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Xi Ruoyao <xry111@mengyan1223.wang>
cc: Richard Sandiford <richard.sandiford@arm.com>, 
 Jeff Law <jeffreyalaw@gmail.com>, gcc-patches@gcc.gnu.org, 
 Matthew Fortune <mfortune@gmail.com>
Subject: Re: [PATCH] testsuite: mips: use noinline attribute instead of
 -fno-inline
In-Reply-To: <mpto8bbn3e4.fsf@arm.com>
Message-ID: <alpine.DEB.2.21.2107230418150.57261@angie.orcam.me.uk>
References: <8f047551a4694778606d615bd22ef619006d044e.camel@mengyan1223.wang>
 <f7ca1d6a-0134-aea1-008b-d8b1a56709ba@gmail.com>
 <9ae500112d9c23f025576c2443c639ba0d0bbc26.camel@mengyan1223.wang>
 <c9bb63e1911b04d4d4de7ef3f1f8b11cd1766425.camel@mengyan1223.wang>
 <mptfsx680t3.fsf@arm.com> <994f86e6-0a97-044b-e437-615cc572c3ef@gmail.com>
 <9c224a13070c22092bd252e34b0f17ad5e550509.camel@mengyan1223.wang>
 <mpto8bbn3e4.fsf@arm.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
X-Spam-Status: No, score=-3488.7 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 KAM_INFOUSMEBIZ, KAM_LAZY_DOMAIN_SECURITY, SPF_HELO_NONE, SPF_NONE,
 TXREP autolearn=no autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Jul 2021 02:21:56 -0000

On Fri, 9 Jul 2021, Richard Sandiford via Gcc-patches wrote:

> >> > > The "smallest fix" is simply adding -fno-inline into mips.exp. 
> >> > > However
> >> > > I don't like it because I agree with you that mips.exp shouldn't
> >> > > care
> >> > > about dg-options, at least don't do it too much.
> >> > As I said in the other message, I think the smallest fix is the way
> >> > to
> >> > go though.
> >> THanks for chiming in Richard.  I didn't know all the background
> >> here.   
> >> Let's just go with the small fix based on your recommendation.  We can
> >> always revisit if we keep running into issues in this code.
> >
> > Pushed at 3b33b113.
> 
> It looks like that was the originally posted patch though.  It probably
> wasn't very clear, but by smallest fix, I meant adding inline to:

 Xi, will you revert your commit that was not approved and apply the 
correct fix?

  Maciej