From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Richard Biener <richard.guenther@gmail.com>
Cc: Richard Sandiford <richard.sandiford@arm.com>,
Xi Ruoyao <xry111@mengyan1223.wang>,
GCC Patches <gcc-patches@gcc.gnu.org>,
marxin@gcc.gnu.org, Matthew Fortune <mfortune@gmail.com>
Subject: Re: PING^5: [PATCH] mips: add MSA vec_cmp and vec_cmpu expand pattern [PR101132]
Date: Fri, 30 Jul 2021 14:13:17 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.2107301408001.62025@angie.orcam.me.uk> (raw)
In-Reply-To: <CAFiYyc0pCy-TDHBZ4gK_EyMY+-0A4MmU3_CBghR0YDLWgTQxXg@mail.gmail.com>
On Fri, 30 Jul 2021, Richard Biener wrote:
> > It isn't really appropriate for me to review MIPS stuff given that I work
> > for a company that has a competing architecture. I think Jeff expressed
> > similar concerns given his new role.
>
> I think that should be a non-issue unless it is an issue between you
> and your employer (I realize some companies even restrict what you
> can do in your spare time).
That is exactly the point, and I understand the ethical concerns even if
such activity has not been explicitly restricted by an employment contract
one has entered into and has been bound by.
> We trust maintainers / reviewers to do
> the right thing(TM) for the GCC project even when it is against the
> interest of the company they are employed by. That is, not push
> crap even if it is in the area of your maintainership.
That I think is undoubtable.
Maciej
next prev parent reply other threads:[~2021-07-30 12:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 13:42 Xi Ruoyao
2021-07-01 8:11 ` Xi Ruoyao
2021-07-09 6:50 ` PING^2: " Xi Ruoyao
2021-07-16 5:57 ` PING^3: " Xi Ruoyao
2021-07-23 12:46 ` PING^4: " Xi Ruoyao
2021-07-30 4:56 ` PING^5: " Xi Ruoyao
2021-07-30 8:04 ` Richard Sandiford
2021-07-30 8:17 ` Xi Ruoyao
2021-07-30 18:06 ` committed: " Xi Ruoyao
2021-07-30 8:30 ` PING^5: " Richard Biener
2021-07-30 12:13 ` Maciej W. Rozycki [this message]
2021-07-30 15:57 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2107301408001.62025@angie.orcam.me.uk \
--to=macro@orcam.me.uk \
--cc=gcc-patches@gcc.gnu.org \
--cc=marxin@gcc.gnu.org \
--cc=mfortune@gmail.com \
--cc=richard.guenther@gmail.com \
--cc=richard.sandiford@arm.com \
--cc=xry111@mengyan1223.wang \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).