From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from angie.orcam.me.uk (angie.orcam.me.uk [78.133.224.34]) by sourceware.org (Postfix) with ESMTP id 7F4B3385740E; Fri, 30 Jul 2021 12:13:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7F4B3385740E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=orcam.me.uk Received: by angie.orcam.me.uk (Postfix, from userid 500) id C474E92009C; Fri, 30 Jul 2021 14:13:17 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id BD6A192009B; Fri, 30 Jul 2021 14:13:17 +0200 (CEST) Date: Fri, 30 Jul 2021 14:13:17 +0200 (CEST) From: "Maciej W. Rozycki" To: Richard Biener cc: Richard Sandiford , Xi Ruoyao , GCC Patches , marxin@gcc.gnu.org, Matthew Fortune Subject: Re: PING^5: [PATCH] mips: add MSA vec_cmp and vec_cmpu expand pattern [PR101132] In-Reply-To: Message-ID: References: <1c61137b2e714a8a45e2b078a79851acc2eb5b8c.camel@mengyan1223.wang> <4bd3eabc82dd007b1ed684aa2f1f720918740986.camel@mengyan1223.wang> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-1162.7 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_INFOUSMEBIZ, KAM_LAZY_DOMAIN_SECURITY, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jul 2021 12:13:20 -0000 On Fri, 30 Jul 2021, Richard Biener wrote: > > It isn't really appropriate for me to review MIPS stuff given that I work > > for a company that has a competing architecture. I think Jeff expressed > > similar concerns given his new role. > > I think that should be a non-issue unless it is an issue between you > and your employer (I realize some companies even restrict what you > can do in your spare time). That is exactly the point, and I understand the ethical concerns even if such activity has not been explicitly restricted by an employment contract one has entered into and has been bound by. > We trust maintainers / reviewers to do > the right thing(TM) for the GCC project even when it is against the > interest of the company they are employed by. That is, not push > crap even if it is in the area of your maintainership. That I think is undoubtable. Maciej