From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <macro@orcam.me.uk>
Received: from angie.orcam.me.uk (angie.orcam.me.uk [IPv6:2001:4190:8020::34])
 by sourceware.org (Postfix) with ESMTP id CB63F3858D28
 for <gcc-patches@gcc.gnu.org>; Sun, 23 Jan 2022 22:02:52 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CB63F3858D28
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=orcam.me.uk
Authentication-Results: sourceware.org; spf=none smtp.mailfrom=orcam.me.uk
Received: by angie.orcam.me.uk (Postfix, from userid 500)
 id CFA3092009C; Sun, 23 Jan 2022 23:02:50 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
 by angie.orcam.me.uk (Postfix) with ESMTP id CD85B92009B;
 Sun, 23 Jan 2022 22:02:50 +0000 (GMT)
Date: Sun, 23 Jan 2022 22:02:50 +0000 (GMT)
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Palmer Dabbelt <palmer@dabbelt.com>
cc: Kito Cheng <kito.cheng@gmail.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] riscv: fix -Wformat-diag errors.
In-Reply-To: <mhng-dcaa55fd-b16b-4cd1-819c-e26dc5f3478d@palmer-ri-x1c9>
Message-ID: <alpine.DEB.2.21.2201232201200.58572@angie.orcam.me.uk>
References: <mhng-dcaa55fd-b16b-4cd1-819c-e26dc5f3478d@palmer-ri-x1c9>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Spam-Status: No, score=-3495.3 required=5.0 tests=BAYES_00, GIT_PATCH_0,
 KAM_DMARC_STATUS, KAM_INFOUSMEBIZ, KAM_LAZY_DOMAIN_SECURITY, SPF_HELO_NONE,
 SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 23 Jan 2022 22:02:54 -0000

On Tue, 18 Jan 2022, Palmer Dabbelt wrote:

> Yep.  Seeing this go by, though, I think there's some English issues with the
> original messages.  I'd write it more like this, but I'm never 100% sure on
> these things:
> 
>    diff --git a/gcc/common/config/riscv/riscv-common.cc
> b/gcc/common/config/riscv/riscv-common.cc
>    index 004822bfe6c..2f83303ca51 100644
>    --- a/gcc/common/config/riscv/riscv-common.cc
>    +++ b/gcc/common/config/riscv/riscv-common.cc
>    @@ -375,7 +375,7 @@ riscv_subset_list::add (const char *subset, int
> major_version,
>           else
>     	error_at (
>     	  m_loc,
>    -	  "%<-march=%s%>: extension %qs appear more than one time",
>    +	  "%<-march=%s%>: extension %qs appears more than one time",

 Or "... more than once" even.

  Maciej