From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <macro@orcam.me.uk>
Received: from angie.orcam.me.uk (angie.orcam.me.uk [IPv6:2001:4190:8020::34])
 by sourceware.org (Postfix) with ESMTP id 1704E3858C33
 for <gcc-patches@gcc.gnu.org>; Sat, 30 Jul 2022 13:22:57 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1704E3858C33
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=orcam.me.uk
Authentication-Results: sourceware.org; spf=none smtp.mailfrom=orcam.me.uk
Received: by angie.orcam.me.uk (Postfix, from userid 500)
 id 2FED892009C; Sat, 30 Jul 2022 15:22:55 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
 by angie.orcam.me.uk (Postfix) with ESMTP id 2CC6192009B;
 Sat, 30 Jul 2022 14:22:55 +0100 (BST)
Date: Sat, 30 Jul 2022 14:22:55 +0100 (BST)
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Dimitrije Milosevic <Dimitrije.Milosevic@Syrmia.com>
cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>, 
 Djordje Todorovic <Djordje.Todorovic@syrmia.com>
Subject: Re: [PATCH] Mips: Fix the ASAN shadow offset hook for the n32 ABI
In-Reply-To: <AM0PR03MB48829B2382BE4B8860AE317282A29@AM0PR03MB4882.eurprd03.prod.outlook.com>
Message-ID: <alpine.DEB.2.21.2207301417590.58390@angie.orcam.me.uk>
References: <AM0PR03MB48829B2382BE4B8860AE317282A29@AM0PR03MB4882.eurprd03.prod.outlook.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Spam-Status: No, score=-3489.0 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 KAM_INFOUSMEBIZ, KAM_LAZY_DOMAIN_SECURITY, SPF_HELO_NONE, SPF_NONE,
 TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 30 Jul 2022 13:22:58 -0000

On Mon, 6 Jun 2022, Dimitrije Milosevic wrote:

>         * config/mips/mips.cc (mips_asan_shadow_offset): Reformat
>         to handle the N32 ABI.

 That's not what the change does.

>         * config/mips/mips.h (SUBTARGET_SHADOW_OFFSET): Remove
>         the macro, as it is not needed anymore.

 Why is the macro not needed anymore?

 I can see the change has already been committed, but no proper review was 
done and I can hardly see how anyone can know why this change is correct.  
If someone looks at it say in 10 years' time they can only try to guess.

  Maciej