From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from angie.orcam.me.uk (angie.orcam.me.uk [IPv6:2001:4190:8020::34]) by sourceware.org (Postfix) with ESMTP id 1F2933858C52 for ; Wed, 21 Sep 2022 16:03:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1F2933858C52 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=orcam.me.uk Received: by angie.orcam.me.uk (Postfix, from userid 500) id 9C85F92009C; Wed, 21 Sep 2022 18:03:54 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id 9741292009B; Wed, 21 Sep 2022 17:03:54 +0100 (BST) Date: Wed, 21 Sep 2022 17:03:54 +0100 (BST) From: "Maciej W. Rozycki" To: Xi Ruoyao cc: YunQiang Su , gcc-patches@gcc.gnu.org, doko@debian.org, Jeff Law Subject: Re: [PATCH] MIPS: fix building on multiarch platform In-Reply-To: Message-ID: References: <20220921113118.520824-1-yunqiang.su@cipunited.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Spam-Status: No, score=-3495.0 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,KAM_INFOUSMEBIZ,KAM_LAZY_DOMAIN_SECURITY,KAM_SHORT,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 21 Sep 2022, Xi Ruoyao wrote: > > diff --git a/gcc/config/mips/mips.h b/gcc/config/mips/mips.h > > index 74b6e11aabb..fe7f5b274b9 100644 > > --- a/gcc/config/mips/mips.h > > +++ b/gcc/config/mips/mips.h > > @@ -3427,6 +3427,7 @@ struct GTY(())  machine_function { > >   > >  /* If we are *not* using multilibs and the default ABI is not ABI_32 > > we > >     need to change these from /lib and /usr/lib.  */ > > +#ifndef ENABLE_MULTIARCH > >  #if MIPS_ABI_DEFAULT == ABI_N32 > >  #define STANDARD_STARTFILE_PREFIX_1 "/lib32/" > >  #define STANDARD_STARTFILE_PREFIX_2 "/usr/lib32/" > > @@ -3434,6 +3435,7 @@ struct GTY(())  machine_function { > >  #define STANDARD_STARTFILE_PREFIX_1 "/lib64/" > >  #define STANDARD_STARTFILE_PREFIX_2 "/usr/lib64/" > >  #endif > > +#endif > > Should we just remove STANDARD_STARTFILE_PREFIX_{1,2} unconditionally? > I just took a look and the only Linux ports using these macros are MIPS > and LoongArch (borrowed these macros from MIPS, I guess). On a non- > multilib distro /usr/lib is likely used, and on multilib distros the > macros are not used anyway. See for the rationale. Has glibc switched since? Maciej