From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from angie.orcam.me.uk (angie.orcam.me.uk [78.133.224.34]) by sourceware.org (Postfix) with ESMTP id BF2DF3858C83 for ; Sun, 23 Apr 2023 18:56:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BF2DF3858C83 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=orcam.me.uk Received: by angie.orcam.me.uk (Postfix, from userid 500) id 90C3892009C; Sun, 23 Apr 2023 20:56:56 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id 81E8292009B; Sun, 23 Apr 2023 19:56:56 +0100 (BST) Date: Sun, 23 Apr 2023 19:56:56 +0100 (BST) From: "Maciej W. Rozycki" To: Segher Boessenkool cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Turn on LRA on all targets In-Reply-To: <283c45ca085ced958cbce6e64331252c83a5899f.1682268126.git.segher@kernel.crashing.org> Message-ID: References: <283c45ca085ced958cbce6e64331252c83a5899f.1682268126.git.segher@kernel.crashing.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-1169.1 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,KAM_INFOUSMEBIZ,KAM_LAZY_DOMAIN_SECURITY,KAM_SHORT,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, 23 Apr 2023, Segher Boessenkool wrote: > 1) Targets that already always have LRA, but that redefine the hook > anyway. These are gcn, pdp11, rx, sparc, vax, and xtensa. Nothing > really changes for these targets with this patch (but later patches > will delete the superfluous hook implementations). Umm, no, VAX has LRA selectable and for a reason it defaults to off: > diff --git a/gcc/config/vax/vax.cc b/gcc/config/vax/vax.cc > index 82a176d3bfc9..17fdc4483797 100644 > --- a/gcc/config/vax/vax.cc > +++ b/gcc/config/vax/vax.cc > @@ -114,9 +114,6 @@ static HOST_WIDE_INT vax_starting_frame_offset (void); > #undef TARGET_STRUCT_VALUE_RTX > #define TARGET_STRUCT_VALUE_RTX vax_struct_value_rtx > > -#undef TARGET_LRA_P > -#define TARGET_LRA_P vax_lra_p > - There are extra ICEs in regression testing and code quality is poor; cf. . I'll have a look into it sometime, but it may not be soon and the broken VAX exception unwinder is more important and will have to take precedence anyway. I have fixing the unwinder scheduled hopefully for this release cycle, but LRA will have to wait. Maciej