From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=SD/f=BI=orcam.me.uk=macro@sourceware.org>
Received: from angie.orcam.me.uk (angie.orcam.me.uk [78.133.224.34])
	by sourceware.org (Postfix) with ESMTP id CD9283858D38
	for <gcc-patches@gcc.gnu.org>; Fri, 19 May 2023 11:27:39 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CD9283858D38
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk
Authentication-Results: sourceware.org; spf=none smtp.mailfrom=orcam.me.uk
Received: by angie.orcam.me.uk (Postfix, from userid 500)
	id 463FB92009E; Fri, 19 May 2023 13:27:39 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
	by angie.orcam.me.uk (Postfix) with ESMTP id 3F38D92009B;
	Fri, 19 May 2023 12:27:39 +0100 (BST)
Date: Fri, 19 May 2023 12:27:39 +0100 (BST)
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Jie Mei <jie.mei@oss.cipunited.com>
cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH v2 0/9] MIPS: Add MIPS16e2 ASE instrucions.
In-Reply-To: <cover.1683871682.git.jie.mei@oss.cipunited.com>
Message-ID: <alpine.DEB.2.21.2305190308020.50034@angie.orcam.me.uk>
References: <cover.1683871682.git.jie.mei@oss.cipunited.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Spam-Status: No, score=-1163.3 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_INFOUSMEBIZ,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

Hi Jie,

 Thank you for your submission.

 Since I was a member of the team that developed this ASE in cooperation 
with the hardware group, I did the binutils part, and it was even myself 
who came up with the name for the ASE in an internal discussion, I feel 
somewhat responsible for this feature and therefore I'll review this patch 
series.  I can't formally approve it as I'm not a nominated maintainer, 
but once you have addressed my concerns I expect this to be a formality.

 It may take a couple of days though as this patchset is moderately sized 
and I'm time-constrained.

> The MIPS16e2 ASE is an enhancement to the MIPS16e ASE,
> which includes all MIPS16e instructions, with some addition.
> 
> This series of patches adds all instructions of MIPS16E2 ASE.

 NB please always document changes between revisions of patchsets sent, in 
the comment section of each patch submitted.

 Also you haven't mentioned how you verified your changes.  Please always 
state that when submitting patches, e.g. in the cover letter.

  Maciej