public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Jeff Law <jeffreyalaw@gmail.com>
Cc: Paul Koning <paulkoning@comcast.net>,
	 Mikael Pettersson <mikpelinux@gmail.com>,
	gcc-patches@gcc.gnu.org,  Paul Koning <ni1d@arrl.net>
Subject: Re: [PATCH] fix pdp11_expand_epilogue (PR target/107841)
Date: Thu, 27 Jul 2023 12:51:43 +0100 (BST)	[thread overview]
Message-ID: <alpine.DEB.2.21.2307270527240.10240@angie.orcam.me.uk> (raw)
In-Reply-To: <f100d384-6fa0-f643-333c-f986e1604d3c@gmail.com>

On Thu, 13 Jul 2023, Jeff Law via Gcc-patches wrote:

> > Question for the experts: how is this handled?  Do I need to apply this
> > change to my workspace and commit it, with Mikael as the change author?
> That's what I usually do for someone without write access.  commit it locally
> using the --author flag, then push.

 FWIW `git am' taking the e-mail containing a change on stdin is I believe 
the most straightforward way, as long as the submission has been properly 
formatted.

 The command automatically sets the author correctly, picking the `From:' 
entry from the e-mail headers or the first line of the e-mail body as 
appropriate, sets the author date from the `Date:' header, picks up the 
contents of the `Subject:' header as the change heading and the body of 
the e-mail sans any `From:' entry as the change description, and strips 
any discussion between the non-commit delimiter (`--') and the patch 
itself.

 The command was designed for maintainers to import changes submitted by 
e-mail so it does what expected.  Any issues with an imported change can 
then be addressed with `git commit --amend', etc.

 HTH,

  Maciej

  reply	other threads:[~2023-07-27 11:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-13 16:47 Mikael Pettersson
2023-07-13 17:46 ` Paul Koning
2023-07-13 18:52   ` Jeff Law
2023-07-27 11:51     ` Maciej W. Rozycki [this message]
2023-07-13 20:10 ` Paul Koning

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.2307270527240.10240@angie.orcam.me.uk \
    --to=macro@orcam.me.uk \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jeffreyalaw@gmail.com \
    --cc=mikpelinux@gmail.com \
    --cc=ni1d@arrl.net \
    --cc=paulkoning@comcast.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).