From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id 5F76C386F001 for ; Wed, 18 Nov 2020 19:06:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5F76C386F001 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=joseph_myers@mentor.com IronPort-SDR: aOPycjVUtcmrXK64KSDYy64AS0caCVpV0NO3JBOZVYQRn/uH3uNlBF+bkXUpohTztLrxNavsuq nb3HDcFafSRdxdkvMzHQCv3uYI8vd7Xss8aj1/IFa/RjzPIz1yTeSoMCPFMxbUKkvo/GE4uc4v PZB8ksehbYVlJtYHLQLJU4vYab6dtm1E48mqfHGluqg7Ve3Lunzs3hHgg61wrV28plg+0L/s8d Zz5fnvOkPK27GMR6rUvrwwCjV5995u2CIGK7GAI8WCq0lu1ct0W3nizBm5G1EaINKwi5FLJ3ws RfY= X-IronPort-AV: E=Sophos;i="5.77,488,1596528000"; d="scan'208";a="55328794" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa4.mentor.iphmx.com with ESMTP; 18 Nov 2020 11:06:55 -0800 IronPort-SDR: kQaO5uxlSoBjiVapmdieAw9ryUiYk4gEvrTl0SwIlO42SgWYyhVnb8LqSdFuo3eo6o2RaV+Fb2 oIgNd+0OwkSCqZIRXca2BrHyOIaF7qCl8NiVH1Wea9J1T8PDJ/Ioysp4x2aU4IHoEQOAaNnOR1 PTT64qcdvNeBG72brtpCtp0Fw3Jug65I5lB9Z/vlRV5Xz5j3JxFAC9paERZ7Y8IgCSPz8zEmJ6 HtLpv9nNFTbr2cTZczQGSADO+qT6cz7Sm1beYR4f3PCyuzLYe+r27i7h5WpIaBHMBOWQVclO9Z mEs= Date: Wed, 18 Nov 2020 19:06:49 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Jakub Jelinek CC: Jan Hubicka , Subject: Re: [PATCH] options, lto: Optimize streaming of optimization nodes In-Reply-To: <20201118093635.GI3788@tucnak> Message-ID: References: <20201118093635.GI3788@tucnak> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-09.mgc.mentorg.com (139.181.222.9) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-3125.2 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Nov 2020 19:06:57 -0000 On Wed, 18 Nov 2020, Jakub Jelinek via Gcc-patches wrote: > Hi! > > Reposting with self-contained description per Joseph's request: > > Honza mentioned that especially for the new param machinery, most of > streamed values are probably going to be the default values. Perhaps > somehow we could stream them more effectively. > > This patch implements it and brings further savings, the size > goes down from 574 bytes to 273 bytes, i.e. less than half. > Not trying to handle enums because the code doesn't know if (enum ...) 10 > is even valid, similarly non-parameters because those really generally > don't have large initializers, and params without Init (those are 0 > initialized and thus don't need to be handled). > > Bootstrapped/regtested again on x86_64-linux and i686-linux, ok for trunk? > > 2020-11-18 Jakub Jelinek > > * optc-save-gen.awk: Initialize var_opt_init. In > cl_optimization_stream_out for params with default values larger than > 10, xor the default value with the actual parameter value. In > cl_optimization_stream_in repeat the above xor. OK. -- Joseph S. Myers joseph@codesourcery.com