From: Joseph Myers <joseph@codesourcery.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Patrick McGehearty via Gcc-patches <gcc-patches@gcc.gnu.org>,
<segher@kernel.crashing.org>
Subject: Re: [PATCH v3] Fix for powerpc64 long double complex divide failure
Date: Fri, 13 Aug 2021 17:22:47 +0000 [thread overview]
Message-ID: <alpine.DEB.2.22.394.2108131718530.20072@digraph.polyomino.org.uk> (raw)
In-Reply-To: <87sfze70k0.fsf@igel.home>
On Fri, 13 Aug 2021, Andreas Schwab wrote:
> On Aug 12 2021, Patrick McGehearty via Gcc-patches wrote:
>
> > diff --git a/libgcc/config/rs6000/_divkc3.c b/libgcc/config/rs6000/_divkc3.c
> > index a1d29d2..2b229c8 100644
> > --- a/libgcc/config/rs6000/_divkc3.c
> > +++ b/libgcc/config/rs6000/_divkc3.c
> > @@ -38,10 +38,10 @@ see the files COPYING3 and COPYING.RUNTIME respectively. If not, see
> > #endif
> >
> > #ifndef __LONG_DOUBLE_IEEE128__
> > -#define RBIG (__LIBGCC_KF_MAX__ / 2)
> > -#define RMIN (__LIBGCC_KF_MIN__)
> > -#define RMIN2 (__LIBGCC_KF_EPSILON__)
> > -#define RMINSCAL (1 / __LIBGCC_KF_EPSILON__)
> > +#define RBIG (__LIBGCC_DF_MAX__ / 2)
> > +#define RMIN (__LIBGCC_DF_MIN__)
> > +#define RMIN2 (__LIBGCC_DF_EPSILON__)
> > +#define RMINSCAL (1 / __LIBGCC_DF_EPSILON__)
>
> How can it happen that __LONG_DOUBLE_IEEE128__ is not defined? This
> file is always compiled with -mfloat128 and this looks like dead code.
I think the answer there is that -mfloat128 serves to enable __float128,
it doesn't change the long double ABI, which is what
__LONG_DOUBLE_IEEE128__ refers to (that's what -mabi=ieeelongdouble does).
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2021-08-13 17:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 16:03 Patrick McGehearty
2021-08-12 16:19 ` Joseph Myers
2021-08-12 16:40 ` Patrick McGehearty
2021-08-12 16:47 ` Joseph Myers
2021-08-12 20:53 ` Segher Boessenkool
2021-08-12 22:17 ` Patrick McGehearty
2021-08-13 17:12 ` Joseph Myers
2021-08-26 15:51 ` Patrick McGehearty
2021-08-26 16:34 ` Joseph Myers
2021-08-26 16:57 ` Segher Boessenkool
2021-08-26 17:04 ` Segher Boessenkool
2021-08-12 20:55 ` Segher Boessenkool
2021-08-12 22:36 ` Andreas Schwab
2021-08-13 17:22 ` Joseph Myers [this message]
2021-08-27 2:10 ` Michael Meissner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2108131718530.20072@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=schwab@linux-m68k.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).