From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 98F30385C019 for ; Fri, 13 Aug 2021 17:22:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 98F30385C019 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: b5US5pmyjpdHQA63zRchIbNFLWf+nPmVUDQIIsQAs2OssddQ64X8W3MwhAZvCbVsA4HMRemfJy /feBC8/FKhM5BvKbleDGcExhvFKBPF9y2X+X6l8syN0GrNM8S6vcDl9V6zmsE5Qg3Ob0fL3ntR 9kPMF6YxdSn2GPzifRKFAed58p3H4KSaPmiEOClnE5sKourwNWE30FCRw/tmGS9cwBuLkEjcmB 3c1JPqBd7+tUFfb9t6BRCpyk3rv8ezQ6jA8NsPZPpEakhVcRpV3qPNzQEAqDDxRte/OciTT2o6 o+C9Qn1Pe0chxoMZie2djz6m X-IronPort-AV: E=Sophos;i="5.84,319,1620720000"; d="scan'208";a="64648068" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa2.mentor.iphmx.com with ESMTP; 13 Aug 2021 09:22:53 -0800 IronPort-SDR: 4o6q5vEJP9/hh0m77iH+Vd7ifuwzTi4gh8OITw8qzlBc8gvg7grN4PhEhCzFB3yXlJTwbFJRxq yEOXYone+rjg3DACDXfY+lehJY3V84ysBMFPcGyqmrNM1Cwl436FDPVKRunz96fzQEJcnxS1wy VwDxyoXiBlwvmLuoPZg//A1rUzjyvYE8kbSXtv1LLLXEmG7H4JNZyZKzlJYqw2EvmgUaWtHPC+ NGr+O9QM51cRxIMf93phHXoiBbRLIn2v/bj6y2eMSsX6d85t+XwuLeGm6pdpu3T9G+N8sM+lIL Uqo= Date: Fri, 13 Aug 2021 17:22:47 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Andreas Schwab CC: Patrick McGehearty via Gcc-patches , Subject: Re: [PATCH v3] Fix for powerpc64 long double complex divide failure In-Reply-To: <87sfze70k0.fsf@igel.home> Message-ID: References: <1628784193-9675-1-git-send-email-patrick.mcgehearty@oracle.com> <87sfze70k0.fsf@igel.home> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-06.mgc.mentorg.com (139.181.222.6) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-3125.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Aug 2021 17:22:55 -0000 On Fri, 13 Aug 2021, Andreas Schwab wrote: > On Aug 12 2021, Patrick McGehearty via Gcc-patches wrote: > > > diff --git a/libgcc/config/rs6000/_divkc3.c b/libgcc/config/rs6000/_divkc3.c > > index a1d29d2..2b229c8 100644 > > --- a/libgcc/config/rs6000/_divkc3.c > > +++ b/libgcc/config/rs6000/_divkc3.c > > @@ -38,10 +38,10 @@ see the files COPYING3 and COPYING.RUNTIME respectively. If not, see > > #endif > > > > #ifndef __LONG_DOUBLE_IEEE128__ > > -#define RBIG (__LIBGCC_KF_MAX__ / 2) > > -#define RMIN (__LIBGCC_KF_MIN__) > > -#define RMIN2 (__LIBGCC_KF_EPSILON__) > > -#define RMINSCAL (1 / __LIBGCC_KF_EPSILON__) > > +#define RBIG (__LIBGCC_DF_MAX__ / 2) > > +#define RMIN (__LIBGCC_DF_MIN__) > > +#define RMIN2 (__LIBGCC_DF_EPSILON__) > > +#define RMINSCAL (1 / __LIBGCC_DF_EPSILON__) > > How can it happen that __LONG_DOUBLE_IEEE128__ is not defined? This > file is always compiled with -mfloat128 and this looks like dead code. I think the answer there is that -mfloat128 serves to enable __float128, it doesn't change the long double ABI, which is what __LONG_DOUBLE_IEEE128__ refers to (that's what -mabi=ieeelongdouble does). -- Joseph S. Myers joseph@codesourcery.com