From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id 751453857001 for ; Thu, 2 Sep 2021 20:03:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 751453857001 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: K08DHP7H0LreDlYVuKcbazyvnTuR5xuL0IMxzpJ2emeGRALx19S+DT9TfgnELEqNkshJxtibX6 gTbvzR0tWISWmS33+sNAxWa0Z0CbtwIedgaNEoNPy/fRGd8uLTCvmyi+vQtlXm7a15ykWisWZ4 pEUga7ojD1gegZJeGjDr3UAKjX33GToBZIC61szGpLTj1Jnxl1dw43HNdqtn93cOAvTOVGXLpC xv5Gau2UG2FmGzHql4gGzqshOkIrL7Ukt4Uf3neVrF09q5Hx70nXR6oAKkPWuagaGWGXukczIM 2ozfoEdewBKB/w8/vikJhwps X-IronPort-AV: E=Sophos;i="5.85,263,1624348800"; d="scan'208";a="65632897" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa4.mentor.iphmx.com with ESMTP; 02 Sep 2021 12:03:26 -0800 IronPort-SDR: pKGEaNMaoNwpTJVJ9kQDVZCl2kYQg8z/SxShQnRzqEAFpHkSpfZxew1m5kEjsPbwJrTQG5HC3x KOpc2ZZLbNhSHclKQxFLexPk7qwEEPOWfU+1XxJMnA57FqEZF2S02VuS4Q+lGuOAY2NQXEy1/G /maHeHkqb21d2oapLZGh85eyXrcJfFo2uOfpbAsBkVNf2nnjvSjGOPUwh963l4gsHx2TMoU+FQ epMzqNNGurYM0PVdc7ghbqQIO9RDPYeOY4/F7hp91H5i29VLJLaWk5xV9l15V77DqtKK/w3OMf RSc= Date: Thu, 2 Sep 2021 20:03:20 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Iain Sandoe CC: Hongtao Liu , liuhongt , GCC Patches Subject: Re: [PATCH V3 0/6] Initial support for AVX512FP16 In-Reply-To: <9D12B200-79ED-46A9-957C-EAFD6C28541E@googlemail.com> Message-ID: References: <20210802063116.999830-1-hongtao.liu@intel.com> <9D12B200-79ED-46A9-957C-EAFD6C28541E@googlemail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-08.mgc.mentorg.com (139.181.222.8) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-3124.5 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, KAM_NUMSUBJECT, KAM_SHORT, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Sep 2021 20:03:28 -0000 On Thu, 2 Sep 2021, Iain Sandoe via Gcc-patches wrote: > diff --git a/libgcc/soft-fp/eqdf2.c b/libgcc/soft-fp/eqdf2.c > index 2a44ee377ce..a3bb664f5f1 100644 > --- a/libgcc/soft-fp/eqdf2.c > +++ b/libgcc/soft-fp/eqdf2.c > @@ -28,6 +28,7 @@ > License along with the GNU C Library; if not, see > . */ > > +#define DarwinMode DF > #include "soft-fp.h" > #include "double.h" All these files are supposed to be taken unmodified from glibc. They shouldn't contain any OS-specific code, such as a define of DarwinMode. sfp-machine.h, however, is libgcc-local, hence putting the definition of strong_alias there. So you need some other way to extract the argument type of name in order to use it in a declaration of aliasname. E.g. __typeof (_Generic (name, CMPtype (*) (HFtype, HFtype): (HFtype) 0, CMPtype (*) (SFtype, SFtype): (SFtype) 0, CMPtype (*) (DFtype, DFtype): (DFtype) 0, CMPtype (*) (TFtype, TFtype): (TFtype) 0)) Now in fact I think the include ordering means none of the *type macros are defined here. But if you do e.g. typedef float alias_SFtype __attribute__ ((mode (SF))); and similar, you could use alias_SFtype in the above. And so keep the changes to the Darwin-specific parts of the libgcc-local sfp-machine.h. -- Joseph S. Myers joseph@codesourcery.com